Date: Fri, 27 Aug 2021 13:04:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for =?utf-8?Q?A?=
 =?utf-8?B?TFRFUiBUQUJMRSDigKYgQUREIOKApg==?=
Message-ID: <YShkMBE3sq8mDa1S@paquier.xyz>
References: <87bl6ehhpl.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="D6owGmyqdXKwRmGl"
Content-Disposition: inline
In-Reply-To: <87bl6ehhpl.fsf@wibble.ilmari.org>
Archived-At: 
 <https://www.postgresql.org/message-id/YShkMBE3sq8mDa1S%40paquier.xyz>
Precedence: bulk


--D6owGmyqdXKwRmGl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 03, 2021 at 12:48:38PM +0100, Dagfinn Ilmari Manns=C3=A5ker wro=
te:
> The other day I noticed that there's no tab completion after ALTER TABLE
> =E2=80=A6 ADD, so here's a patch.  In addition to COLUMN and all the table
> constraint types, it also completes with the list of unique indexes on
> the table after ALTER TABLE =E2=80=A6 ADD =E2=80=A6 USING INDEX.

I was reading this patch (not actually tested), and that's a clear
improvement.  One extra thing that could be done here is to complete
with types for a ALTER TABLE ADD COLUMN foo.  We could as well have a
list of columns after UNIQUE or PRIMARY KEY, but that feels like extra
cream on top of the cake.  In short I am fine with what you have
here.
--
Michael

--D6owGmyqdXKwRmGl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmEoZDAACgkQnvQgOdby
QH2fww/9Fp64k3hwKgIjn61oH7c+1MiZquKZsZev4bB4TzgkVzIbhdnzT8IHS9Gr
6QFrppYAgGPjt4h8Hj4pJ1OvEWl28Fmv6C7pRtsceRetXU0LIQHzGdP7OAZ1Yu/S
h4DS5lxQJ6U+To7ZfRe2w/lmkJMHa9NVCF8HfeJWV4TO5jt9JgOeS0d7ya97bUvo
iD80y1UKVzVcL2Veg7IRbWzPzdbGMaM5Rl1fD+I87pe8qrBa3Y6Mc/GPoX5b3yA+
m5pxgVoDCAKkbRi1UeNtdOZyi5hTAPZx4Oj7oej8QLxl9hDc76YLyQ7Ep8SHsWvw
Aqio7Yl0Seq36QmI32H3Is+emV8yFw70Yh0XJVaB6O+x1jFjdxxfYygmzl92fIXl
GG71tkjfMWTc6/A595PnuKqR1TwJpbJ5xAYD4iME1kGXQCl1jXTHsEMKB9YnSyys
sJeIpRy7wmCYvwd+sYFAH+yqgmdW5vatYc5BoxUKZd8vM/CjT2jbv5CS+xfrHsKO
52poN36XmQe43yjfzft7iP8SDvbG07/3KAyIDw5k6QsH+LaqbmO/id6GczR+JIm6
aABkGTb1FYvnqsTZNeEIoSHeQL59n3kOGVPSvia6SqDXY6ZtcU7sZMINXznzB703
OvHDDq6q7q6LIBj8ddcS3XPAdBkI5PXcGJwYJHUtktqAoxSYAJg=
=5XnE
-----END PGP SIGNATURE-----

--D6owGmyqdXKwRmGl--