Date: Mon, 30 Aug 2021 09:55:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for =?utf-8?Q?A?=
 =?utf-8?B?TFRFUiBUQUJMRSDigKYgQUREIOKApg==?=
Message-ID: <YSwsmd44F3tjFyLI@paquier.xyz>
References: <87bl6ehhpl.fsf@wibble.ilmari.org>
 <YShkMBE3sq8mDa1S@paquier.xyz>
 <87k0k7upla.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="jwBfl1aKeQemiJFS"
Content-Disposition: inline
In-Reply-To: <87k0k7upla.fsf@wibble.ilmari.org>
Archived-At: 
 <https://www.postgresql.org/message-id/YSwsmd44F3tjFyLI%40paquier.xyz>
Precedence: bulk


--jwBfl1aKeQemiJFS
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Manns=E5ker wrote:
> That was easy enough to add (just a bit of extra fiddling to handle
> COLUMN being optional), done in the attached v2 patch.

This part was a bit misleading, as it would recommend a list of types
when specifying just ADD CONSTRAINT for example, so I have removed
it.  An extra thing that felt a bit overdoing is the addition of KEY
after PRIMARY/FOREIGN.

> Doing a list of arbitrarily many comma-separated names is more
> complicated, so that can be the subject for another patch.

No objections to that.  I have applied what we have now, as that's
already an improvement.
--
Michael

--jwBfl1aKeQemiJFS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmEsLJkACgkQnvQgOdby
QH0H4RAAglC6TgQd2CpNlQr1lKVesaCQ6zxvco5P8uB7pQajYZW+6RkvDFYaeipe
smGlkq2DjODUCQoz04uD35gy52sQk5+YzqwALS8e5R6oyOg8DRCf/JyAHkD1Hdbp
TOjSp45XIzMaAfKDNUz6FMigrqsUwRIGnsZQE5ygI2lgdBbQq9zrVkN2jIzrFsbe
FYL9qeoCu76ORfq9Zmawv12qaDuEffEkKaGT8JCR14+XpOjaNmRT/uIUlRxuZSjv
IvnLwUbobKv1O6uTWEpYO3WAS081HcYAb6GxHASgGAL71JRlGv4vwMxakuZUx3wj
InmfINtY5kSgOez/wakwkzxBeez0hUTLOI68z3Nq1Xvj3ajiPBrKC72SC4toyf0j
2ifS610NSZhrwTJxEDjRreLvnURa7QAcK8wMjwG9jC6al++0faSbdxWWmwMQPlQR
mKm80CyWnXfabFB/b7RWBiICghGwsy+ZN/fEpK9LZAuu0OKkzcc8XCre88mGZcoM
YGpFuzJzF76tEYRvfjy+8CJbjq1PWO3mzKBf8tV7CqDj6mZw8APkluzYAJ6iIQRB
LwvHcWQrofVhUUd7Qe/JoVCRg9O6/U6LKWMD9FyW+HfXvW5o0IMX0bMtj94QZSK/
dThkLI4iS/ZxkWXJGwHiBHsZOhZpLykj7FQje34uow2Eqpeh7S8=
=cY3w
-----END PGP SIGNATURE-----

--jwBfl1aKeQemiJFS--