Date: Wed, 22 Sep 2021 16:39:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Proposal: Save user's original authenticated identity for logging
Message-ID: <YUrdnoEc4NPfBZfI@paquier.xyz>
References: <4a87886f034c713c056c43850f55e6e0ba50d8b5.camel@vmware.com>
 <YGJ3FoOfgSao9Cv8@paquier.xyz>
 <e0f0484a1815b26bb99ef9ddc7a110dfd6425931.camel@vmware.com>
 <a4fddbcd2f99c293991b7669bd0da3e5a7d3f93b.camel@vmware.com>
 <YGQk74rdCdb8F9gZ@paquier.xyz>
 <YGUgHMF9zxNvY323@paquier.xyz>
 <d17b919e27474abfa55d97786cb9cfadfe2b59e9.camel@vmware.com>
 <YGaha/euiRjZ820X@paquier.xyz>
 <YGhf4TN6ukOZTUcd@paquier.xyz>
 <ae1143fb-455c-c80f-ed66-78d45bd93303@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="IBeMkoxnW/8HB5nC"
Content-Disposition: inline
In-Reply-To: <ae1143fb-455c-c80f-ed66-78d45bd93303@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YUrdnoEc4NPfBZfI%40paquier.xyz>
Precedence: bulk


--IBeMkoxnW/8HB5nC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 22, 2021 at 08:59:38AM +0200, Peter Eisentraut wrote:
> I noticed this patch eliminated one $Test::Builder::Level assignment. Was
> there a reason for this?
>=20
> I think we should add it back, and also add a few missing ones in similar
> places.  See attached patch.
>
> [...]
>
>  {
> +	local $Test::Builder::Level =3D $Test::Builder::Level + 1;
> +

So you are referring to this one removed in c50624c.  In what does
this addition change things compared to what has been added in
connect_ok() and connect_fails()?  I am pretty sure that I have
removed this one because this logic got refactored in
PostgresNode.pm.
--
Michael

--IBeMkoxnW/8HB5nC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFK3Z4ACgkQnvQgOdby
QH1H7hAAkAkZeJosUeZWtrLPqj4/0D39i6Zfz88CS1rP+P7zkrfbQeysB08r0RO6
3ERyRk8fnDSQXbUcH0uGnjpYxm2UvFrqC4EIjYREk5+cmJnYwtYd64Kid2fRd7mr
d8nHn4K32WQcDUnG8zbyRJ6WpXFLPUUvDv2OeJhVn54uRFT7PpZ0aLkRH8S7wiU5
z1oTh4C3LxFH5jWxeq5cWtAOhDCJKtGq1OedrMh2SLopAUdXeYTEv25FYFFh28Y3
HAP6yi17AZT7thUnEkFw3L3AFOQlgH7nnh2zP4NfAsNYHWlGsk3sZOvXOP3xgtBG
yKv4QjO3LWE42Z1EX5gOl1E33bwHSe0VlXo6TQ99wwho+eqJpPiXGZzC6Y7d+3Ko
naOUOw9/siiHlb5PUgIhZkP5YiZVfA9LtU4bPaE+r+i9Vc+U6/JH4Y+g+mJYNcSD
xhahY95uUpElLtKETud+bNJwDk7TMY0Zbv7jdGvdk4QqaZV2FAjuF36/aLh8uwnW
dxea3za/JcIG53vVqexlREVaIz0fytx0FfosA5OOuVAfsA4oUcL4MwaAKjSacBXs
6dP+e6y4/ys2fMXW/io0JhPMbgMqdJ9ZgnXpSNspV+6CIcmvF6YL5Ow6NcXfoAwn
Z9I4NZmF2/9ioDBL9mlHe+eFhw+mX5XvYb7gsfXH8UoDdchzSPg=
=IW5R
-----END PGP SIGNATURE-----

--IBeMkoxnW/8HB5nC--