Date: Tue, 28 Sep 2021 08:53:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>, Zhihong Yu <zyu@yugabyte.com>
Subject: Re: typos (and more)
Message-ID: <YVJZf6XEkdZtAF14@paquier.xyz>
References: <YVFVZn28+2+Hjbc2@paquier.xyz>
 <202109272104.7t253iw236fb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="24feeG71qQ3LEsGo"
Content-Disposition: inline
In-Reply-To: <202109272104.7t253iw236fb@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/YVJZf6XEkdZtAF14%40paquier.xyz>
Precedence: bulk


--24feeG71qQ3LEsGo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote:
> Initially we just used "statistic" as a noun, which IIRC was already
> grammatically wrong (but I didn't know that and I think Tomas didn't
> either); later at some point when discussing how to use that noun in
> plural we realized this and argued that merely using "statistics" was
> even more wrong.  It was then that we started using the term "statistics
> object" with plural "statistics objects".  Going back to using just
> "statistics" is unlikely to have become correct; I think Justin's
> patches 0008 and 0012 are correct.

Thanks for confirming.

     if (list_length(pstate->p_rtable) !=3D 1)
         ereport(ERROR,
                 (errcode(ERRCODE_INVALID_COLUMN_REFERENCE),
-                 errmsg("statistics expressions can refer only to the tabl=
e being indexed")));
+                 errmsg("statistics expressions can refer only to the tabl=
e being referenced")));
This part should be backpatched?  The code claims that this should
be dead code so an elog() would be more adapted, and the same can be
said about transformRuleStmt() and transformIndexStmt(), no?  That
would be less messages to translate.=20
--
Michael

--24feeG71qQ3LEsGo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmFSWX8ACgkQnvQgOdby
QH3LHBAAqKEfx3MFTHJyiPaEefbECmNgmYfG2UO75KeLsZseitadybm80Rim4W1e
Wf+ac2CdJGfN14sI0lE2k9cgZgpYSzlDpH5lCTkcc40KyRhZopC5jHVXWW0IpqcB
+QtI0G0tqm2rqZuKVLb7+cdFRRts5KRTYohlTqoKqlLZpmQNdl9YjmY2VzbBdjh1
yKXHYwocaotgCi7SRiyeKizy78s94r5RnIzVqfeZYmxMVjfZ0HXaGFjSgu5ZFf/H
X6f7/CXWT/DcLE9NA1P2fgzGkI1v4xByQA2zYq0EobUfDlnOTAXBhc0NdDqbxRsc
e5t8nHDmJ4FD7Q5enI41qCoAx4XrKE8dlaV1PGsl1tb1pliXO0VrxcZOoEi6EnkO
EwgoihIXEhISdBpTaspow1Q22DmnvQvaCF7MyVyannhL7PkfZHRZww5Hqnlj8BpL
IlEhYfJsCp94fAib6a2NmShX/VVivHPr4dqRrTG2Gf5nPr9HmKQ4OJ5V36cWdRkP
wyc4jXjt5LBabX2DBffUiJ6PQ57jK8eF7zcp3kFdlX47gY8iMRhlR9bEw2szGhkz
YNyjf4VAGC0FghQdrGMvkry31KU5oYXyAUmhwuw9/KZPO/GaiayMDTHf5z+XPtyC
QdgiZVK3pH9Pd9aH1zJB8NX120JGNg6xNbl2imlubHl75iL9B6A=
=Oq6K
-----END PGP SIGNATURE-----

--24feeG71qQ3LEsGo--