Date: Wed, 3 Nov 2021 08:23:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>,
	Georgios Kokolatos <gkokolatos@pm.me>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Message-ID: <YYHIgrTDI0dEPzoj@paquier.xyz>
References: 
 <2sv1K4rAd0hZl65M4_N_yavaqHXnYQJRZOJFK8zMYiHRZsR1BJvXzprxTqi3IzangO5hyuZC5ES-VulHvIU-8B7zJGr15wgF4Dlfbfp2QRk=@pm.me>
 <YUWEqIe4Bx6Q4lcm@paquier.xyz>
 <8CDVNs7db0aITUJjQ8TkK6pX_mO3vTVdpr0niTKodjcNw8DnUIK1fUWHeTYf9oYQP3YfizJT5XevtKdp7xJ04LU_yRI7MY8pPutua3eQAUo=@pm.me>
 <YXvdOb6yo/xxfVce@paquier.xyz>
 <YX+gpFH2s9MG5X3D@paquier.xyz>
 <ckv-SMbj007n51oOS99W6bUCnNvGr4L93Ucse0iTtVj8xSr6_Ws-Zbd6yY4QMUjQHryR4WiemSre8biogFTg1L1kxaYr2FdNZVx-YmTcW5g=@pm.me>
 <YYBp5nmTAy5Xe0pi@paquier.xyz>
 <YYD8Ifj0g4PGlWie@paquier.xyz>
 <CABUevEyWmN-1ksHT6gnsC_e7x4AJSUr+xz=NeOo60ESKNeTntw@mail.gmail.com>
 <CA+Tgmob3Y=m982YPpZ2HCGMdLMvEGH3FrJvx3dKogPTcS=WV+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wBRYUGQP5SJzWRZQ"
Content-Disposition: inline
In-Reply-To: 
 <CA+Tgmob3Y=m982YPpZ2HCGMdLMvEGH3FrJvx3dKogPTcS=WV+A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YYHIgrTDI0dEPzoj%40paquier.xyz>
Precedence: bulk


--wBRYUGQP5SJzWRZQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 02, 2021 at 12:31:47PM -0400, Robert Haas wrote:
> On Tue, Nov 2, 2021 at 8:17 AM Magnus Hagander <magnus@hagander.net> wrot=
e:
>> I think for the end user, it is strictly better to name it "gzip",
>> and given that the target of this option is the end user we should
>> do so. (It'd be different it we were talking about a build-time
>> parameter to configure).=20
>=20
> I agree. Also, I think there's actually a file format called "zlib"
> which is slightly different from the "gzip" format, and you have to be
> careful not to generate the wrong one.

Okay, fine by me.  It would be better to be also consistent in
WalCompressionMethods once we switch to this option value, then.
--
Michael

--wBRYUGQP5SJzWRZQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGByIIACgkQnvQgOdby
QH2+Ng/+L8sN/e29lYDbwtm8uJEYn3bHJ4X1XwA+xIP8Qc4MMxxhG2NV5GULnhwr
eHKaeRAuDIpqwqUy+BNYbd1HncwJXFeuuvP9RN41U4NicVstsguNR0vYjc2GuGRK
WZWIUUFLs6oq8O66kSsMIal3aShAWxnK8zuG/ZvyZ8OQWON/mBhKAYEFOGiKvuVv
IzFOIHm1OXnXBN5YUwxyp8ynJ22xFYDAnLke37YOnzTRguFbiHNn9WPTc9NfZBvL
sfGWk2fu7wpuq8Vi9LWgt0Qe+pQtyCLrtDqegwvnxmq4tSrtr9NqpNh4u14DfNBu
z4eszZW80vw//2uFHr2++T8jNhYDgK9kRvgdM/MaUaFkKGoPxtJeg+PYcYYTMnYX
InanV+WETHw9X9fmceBktSr9dA/gl+UKKLArRT4MABXihZzt3RLeBoqoJPeLVJD4
fxr5d+rS0PYHKSqyat7IAqLKaECRN3e4iSMNvh3WNFoZAvBxiH5Qrzl+0wCVOmHE
4PklXeNG6Sz/E6WTzuFmUMCes2TlUlLqEU+oq/n6sXMcYGb+fYRIgXJ+q/njiImj
uyHkeYI5m8qVz4ijR0D3Q98cCJNLxwcdV2xnOF0LKZFkDGbt3CWRPkCbu46km8Jx
86QizCwk1JulBtKrCNGJejoxeZBVFb1xgPp9L1D52YrLzhbN6/w=
=9/2+
-----END PGP SIGNATURE-----

--wBRYUGQP5SJzWRZQ--