Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkGIg-0003iy-0S for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Nov 2021 01:51:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mkGIe-00024r-Su for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Nov 2021 01:51:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkGIe-00022t-F6 for pgsql-hackers@lists.postgresql.org; Tue, 09 Nov 2021 01:51:48 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkGIc-0004ws-Ao for pgsql-hackers@postgresql.org; Tue, 09 Nov 2021 01:51:47 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4F79C32008FD; Mon, 8 Nov 2021 20:51:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 08 Nov 2021 20:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=aOtOHJb4d8EAOspQN6n8uCgc7/n LX91+UKwyQ2tlmEs=; b=NaOgBmUuhlChyvvgIoW/Rwiy5kIKb3im7HP2V98VNs5 bdTS1+BCtb2yIhbpFuB+RqbdoENqY9g1DaQgEIuoNxT6wlyf64k1k4aS0WnQEPxQ 9X9HPJwdECHKYjY+Ktq7gI36ycKQK539YljBOjD7DstXx1F8j+cXAsjJtMZ16eUW rQnzbVUlcairku6R/mvedSpITBH1Ybf2hoEFyvYSVEOWsAQSS6MmwrjTDvOZVP5U +AP4YshnSB0+W+p85MIOIArwqzQ4gJ/Xicy67n/S/Ts4TlFjIB78dMX7/CrLcY9G u3Ysuw+mSNN0ZM+1yEdmIllvt1WThs18YnNwI041jZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aOtOHJ b4d8EAOspQN6n8uCgc7/nLX91+UKwyQ2tlmEs=; b=ZNMt6/0QGoI/cDUWGsnlHg fkAhg0yGp0bnGNr2iU/cDFfDPQsz1oXIr8QVBxpunBvoUGhlXVNu9UnQ9eiZAvzl Yqpe2Yz746bJvMiZh+Aub3+fqt9qy6LIPwCB8hvNcFavAEbVQiacIugrFhIKCAu1 jy0etzsmIx/al3YoMPuVyIzgMXSIcp4pEMjeJA/LyGio9cjq7NbH2CVhYPDM+Omt ktY+4/O3DXP8JFMiGDTQRMNiNN+glDmAuMUrIkbiWHHaxoKqmBLUKrQxwvXsd0pN 6tOChdvExgav+jP17ntv3/rWqFEKXcA1tRxZ4eyZy0wK52Z0W04EJu1Y5Wv9yArw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepffdufeeflefghfekudekkeevvddu gfeiteekkeduleefvefhhffftdduffeiuedtnecuffhomhgrihhnpehpohhsthhgrhgvsh hqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Nov 2021 20:51:42 -0500 (EST) Date: Tue, 9 Nov 2021 10:51:40 +0900 From: Michael Paquier To: Noah Misch Cc: pgsql-hackers@postgresql.org Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData() Message-ID: References: <20211107013157.GB790288@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1UtHtw1xxXEVAAGi" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --1UtHtw1xxXEVAAGi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 08, 2021 at 01:42:46PM +0900, Michael Paquier wrote: > Indeed. Looking closer, I think that we'd better improve > DecodingContextFindStartpoint(), > pg_logical_replication_slot_advance(), XLogSendLogical() as well as > pg_logical_slot_get_changes_guts() to follow a format closer to what > you have in your patch, with an error message that describes the > context where the problem has been found, instead of just elog()'ing > what XLogReadRecord() returns. FYI, I have just begun a new thread about those ones: https://www.postgresql.org/message-id/YYnTH6OyOwQcAdkw@paquier.xyz -- Michael --1UtHtw1xxXEVAAGi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGJ1CwACgkQnvQgOdby QH2TcBAAgPTKeXxWIEwpPGM2Hf98c2T6yG5uD2rnEDeobgETbtusXMj1pUEXcvcH 7opCPKgPEwdQLuBvlFzs1vHKSntRNUATAnNSKZQoMO/CFJ0nE5zS5xWIFJuJroNB qfIYlUVqfmDGXqG1LVf1cYp+whL9EFhum4tjsC//Whymcqdpz2wPWZtEotD8U+27 EBc9g17BMaZWfxcZACma2BpjfauRoi/UDq180L+hbxR310/gwAjmdduhSt8p4qzq xf0kGIYuTfri8Io86+XvPL5BvQawZNcBnqHHAW9yzIazROy5tBfLLvlb6fXiE3an io1XpnQ1TUPuqThQuJ1gk8TrBm592BMAh1+Cij5jUMg1FXcbSEsdVmUMGSc487Br 2mjjP/lE+bncz51FGK2CoZy9+z3VrqBKR3w2eAnCziP86/QK8ZFGD+tSbACaAho5 Ebv1H4XIwuqnizZ9Auecf8WBESv1R5To8GlMk4eezjo4W2KBX/aQbZd0dG3dDrIS e4CsdXz2ZRME0dtlgKmzPAx6dnJ7eE5trFu0K7GRGvQ0KFRNVCe1jN60LrFXyezU /7uOr93W/lz7Viyh6enCBdi7Su2fChqaT3fBeCILb/AFJ3ZtXCy4S4B8/okpaIl9 nQ31Om2XX7KV248opUNnR8162Rhv6cOCRABHdi4zF/9rr746lr0= =bDxl -----END PGP SIGNATURE----- --1UtHtw1xxXEVAAGi--