Date: Thu, 18 Nov 2021 13:36:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Jacob Champion <pchampion@vmware.com>, tgl@sss.pgh.pa.us,
	peter.eisentraut@enterprisedb.com,
	pgsql-hackers@lists.postgresql.org, buschmann@nidsa.net,
	noah@leadboat.com, tomas.vondra@2ndquadrant.com, bruce@momjian.us,
	andres@anarazel.de
Subject: Re: pg_upgrade test for binary compatibility of core data types
Message-ID: <YZXYYilLM1exwk2v@paquier.xyz>
References: <d9f14840-9f6e-183d-f43a-9f9b9e1b6d19@enterprisedb.com>
 <1575064.1615060903@sss.pgh.pa.us>
 <20210430183348.GQ27406@telsasoft.com>
 <a31d593da98da15fc2302a16b3f3b32e491d3e49.camel@vmware.com>
 <20210912005116.GF26465@telsasoft.com>
 <YVa/se5gxr1PsXDy@paquier.xyz>
 <YWPNxDWFia+V4Y4g@paquier.xyz>
 <20211107192200.GK17618@telsasoft.com>
 <YZSov33oDwW44uMs@paquier.xyz>
 <0b8ebc97-829c-4a40-efcc-761f52bffb0d@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="S07B9Q76cozxJ2+T"
Content-Disposition: inline
In-Reply-To: <0b8ebc97-829c-4a40-efcc-761f52bffb0d@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/YZXYYilLM1exwk2v%40paquier.xyz>
Precedence: bulk


--S07B9Q76cozxJ2+T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 17, 2021 at 10:07:17AM -0500, Andrew Dunstan wrote:
> In general I'm in agreement with the direction here. If we can have a
> script that applies to back branches to make them suitable for upgrade
> testing instead of embedding this in the buildfarm client, so much the
> better.

Okay.  I have worked on 0001 to add the table to check after the
binary compatibilities and applied it.  What remains on this thread is
0002 to move all the SQL queries into a psql-able file with the set of
\if clauses to control which query is run depending on the backend
version.  Justin, could you send a rebased version of that with all
the changes from the buildfarm client included?
--
Michael

--S07B9Q76cozxJ2+T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGV2GIACgkQnvQgOdby
QH1edw//b5HhQ4xH0LREQtFKP+b969K0rNiUg0FTu2MZ4mZcreJbHweD17cxz6V0
A492lmkyCGmySx0fvjZ8I17+7p4WH9tKTSk/WcVvWwhdu2nFP9nwpDhLl6mdAQBG
/xA4jYkw5ob0bXK8DFQYuelfKVtLepAdgn9c4xi8yu4TwjQMB9qRF2NvPmvCoPXY
/xUt3pAaGtlvOhSbJ9HhbZSt87+80CYAb1BOYOyjvw/Hf2wKLm8uRIlBQ6IH+NpR
jYhDV4auI91KUJNyRJFffla5UMyWg6YhAkL9THxykiCMwhG1NirPZIIACU7w474C
pLGvEAppdUljydvacSDdpd1q23TnsRSmRL9YaFiXiGqF/ZKELoKqaBvfAEpNaJUm
xOhKs0sa/vVLx/gdLB7IN8taNHXi1obp8LdHypbWr2FTHXym6aWZILCV3YsWxdBo
Z5/THRh+SSdhIcOhyqfko+k3QyBjcHcWH6rk8IJmuKHIsDUEWmDX/Q4qz9NT+xH1
tei6hl/E3dtiDYrCbj809PN1ObMzvX1lsYt9fp9F/j/nvXspE9RDOHq+T6NtKxBS
e9KP7QyO8oEhDyszebzDcAf7S1qBeI9ctfvdHb1Cu5sliS6XOwyy+3YeIJEIAcPY
few6mSOxIOS7BcfqP9nPi/hcmBg3VwwaUNmyQM9wxykbu/NpDyQ=
=GKB2
-----END PGP SIGNATURE-----

--S07B9Q76cozxJ2+T--