Date: Mon, 6 Dec 2021 15:58:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: GUC flags
Message-ID: <Ya20nxtRYfkg2jd6@paquier.xyz>
References: <20211129030833.GJ17618@telsasoft.com>
 <YaSJcceKORqKS+cM@paquier.xyz>
 <YaXGfc+tRYFFN+bo@paquier.xyz>
 <20211201075904.GW17618@telsasoft.com>
 <YadjSDYGxYEO5k/R@paquier.xyz>
 <20211202033439.GL17618@telsasoft.com>
 <YahVin9880J9W45Z@paquier.xyz>
 <20211202051734.GN17618@telsasoft.com>
 <Yaltp7EjWny7Gl4e@paquier.xyz>
 <20211206053805.GG17618@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="puI4QP+r7HZeO9Kn"
Content-Disposition: inline
In-Reply-To: <20211206053805.GG17618@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Ya20nxtRYfkg2jd6%40paquier.xyz>
Precedence: bulk


--puI4QP+r7HZeO9Kn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 05, 2021 at 11:38:05PM -0600, Justin Pryzby wrote:
> Thanks.  One more item.  The check_guc script currently outputs 68 false
> positives - even though it includes a list of 20 exceptions.  This is not
> useful.

Indeed.  Hmm.  This script does a couple of things:
1) Check the format of the options defined in the various lists of
guc.c, which is something people format well, and pgindent also does=20
a part of this job.
2) Check that options in the hardcoded list of GUCs in
INTENTIONALLY_NOT_INCLUDED are not included in
postgresql.conf.sample
3) Check that nothing considered as a parameter in
postgresql.conf.sample is listed in guc.c.

Your patch removes 1) and 2), but keeps 3) to check for dead
parameter references in postgresql.conf.sample.

Is check_guc actually run on a periodic basis by somebody?  Based on
the amount of false positives that has accumulated over the years, and
what `git grep` can already do for 3), it seems to me that we have
more arguments in favor of just removing it entirely.
--
Michael

--puI4QP+r7HZeO9Kn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGttJ8ACgkQnvQgOdby
QH2a3hAAgV5fSy5zk6ax/WLQQJGsT29XLcsV5D3wEs7rutcszIZtH83fYKUjtn1k
7ARs1/VUYAbFRHgEh0SY6XzcjOCA2pQnKsJDve3VUv/z6mc4Os0+8QT6Ww0LEG+i
op48HcsRCuSa9U0CJEsR4zBJIQw4lavCwGZ+fmJdy5TMbciO2IVvZcVQokfxiZK2
rMomcgM1iBJZIwH1XVc1XWRf+Q+EXRYkj8E+f3YxboKIuK0qGCYFhdzmbb+Fm/NS
/jFY/9z48M6YcBo/oAd0WRikcnFCkOCt40oV/yGkW0CAAWr8G6eVdLflbQAO35HA
R45oEoe4y6FypLGUD6dh8gCGHU0xTjwKfKpRcYwmJq2M4Wyn2KyPo8udjsdivB4O
qO017iIWldY7wVl7XfjrqaxvrAC441Z8W/It9EnzXDxWzq2ekpIYzUAzrwFcsIT6
PrtScO1naW7hPr7EB3yfDK725Xs8quzoGF+WAJD4jLlammtnsd0tqQ3KN/t5VwlR
4u1qXYX7h661WQC8BpnkC1jmmqM4Veaw8ThSkQQJ8HH3yzvPEzJwgqmjxvG4jM1F
nWNzoDnLCduba3cg7AL0KbSw6zOERgXnHYozw0eIHGN0Jo0VelitDNuC8orAcuVg
pUSJPnLLegGmuUpfDTTQaXFFSCdLVG6lJpMKFxKQjwJsftQKeUs=
=hCPk
-----END PGP SIGNATURE-----

--puI4QP+r7HZeO9Kn--