Date: Wed, 1 Dec 2021 09:54:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Bossart, Nathan" <bossartn@amazon.com>,
	Stephen Frost <sfrost@snowman.net>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
	SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Message-ID: <YabHupPdb5PT0YsN@paquier.xyz>
References: <YZ7Amotspa4ve+91@paquier.xyz>
 <CAHg+QDekOasWArvmPeOqhyTUHR40DsDOWyt7OaKxpQ7eFYqysw@mail.gmail.com>
 <YaB3Oj4GfPOZ/3LC@paquier.xyz>
 <417711.1637940660@sss.pgh.pa.us>
 <20211130142042.GR26257@tamriel.snowman.net>
 <3404870c1a921bafbcd168c098088981fe082ab1.camel@cybertec.at>
 <CAOuzzgoYqzH+c_fzapjGFh6kiZjXDc0jPCQctbQjajn7a4vyxA@mail.gmail.com>
 <845544A4-0B0E-41D2-903C-C8B9E8A18812@amazon.com>
 <1661037.1638311167@sss.pgh.pa.us>
 <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QWANPC1kE0EY0oZC"
Content-Disposition: inline
In-Reply-To: <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
Archived-At: 
 <https://www.postgresql.org/message-id/YabHupPdb5PT0YsN%40paquier.xyz>
Precedence: bulk


--QWANPC1kE0EY0oZC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 30, 2021 at 05:58:15PM -0500, David Steele wrote:
> The main objections as I recall are that it is much harder for simple backup
> scripts and commercial backup integrations to hold a connection to postgres
> open and write the backup label separately into the backup.

I don't quite understand why this argument would not hold even today,
even if I'd like to think that more people are using pg_basebackup.

> I did figure out how to keep the safe part of exclusive backup (not having
> to maintain a connection) while removing the dangerous part (writing
> backup_label into PGDATA), but it was a substantial amount of work and I
> felt that it had little chance of being committed.

Which was, I guess, done by storing the backup_label contents within a
file different than backup_label, still maintained in the main data
folder to ensure that it gets included in the backup?
--
Michael

--QWANPC1kE0EY0oZC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGmx7oACgkQnvQgOdby
QH2c5g//RkSwI7LDu9oVZ/dq/Juli/Ez3It5LdCwYnS0aCopjE0dDsvUZ8aSHx5X
sNR9ZRXrYNZsWMP/8oBOg2G/RpMmOBJOXuWdwICqcEEnTC3+vEhpaLPqStIiWp/b
tbiFf8NO8Xw94zTWrjJZBRDww4qTmFrz+6ysSX3QmuTtdbpWJBJNA1oNYqhY3DAW
jBUJhCzUgXjb0dCwRy5l+V9HL8/XXyXIMV0F6JxxkDsa8v1pYsRfq5WEp2f02TVP
AcR8iOFlp0og4J5L7woBzfRrRD2JzTZAd9kmU1AbVjEKqowcGAixPDfDv1tt3bSE
i1TDlRSiDJvwV0HGN+akRCkdC36lhcqyIJK8q9bNpL46SdCgFuSGVfK2PN7W4+jj
8bON6ABXDxC0t8vTZARrNb3BvE7YRI2cdtt5N1coyPQ7yag/KY+xiTmWPYONxt5/
ebSYh0mx62tB6f4i7u1DE8WFKwRWWVqiiGqNuCW46Yffxbb9m9LFBB4bLlZRgDsQ
rjy9CPAyE/FDe4ep6HdfInrldGSP7lL/4kyYvf8N7ZpvgvOoESV1HuSUCfuON3N5
Wi9RY9tSdSXbTNrpszCTgAGLTnDf5z/pKk8+myjkLlOgSFTs/cNbYm0r+BJS9R53
vk+lm5ts4+g93hK4VLLQgMJNDgIee92YhWVN/mFngy9Z+qPYmjs=
=UwxH
-----END PGP SIGNATURE-----

--QWANPC1kE0EY0oZC--