Date: Wed, 8 Dec 2021 17:14:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: enable certain TAP tests for MSVC builds
Message-ID: <YbBpViH/EIJ2ZgBO@paquier.xyz>
References: <17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net>
 <20211205194755.GA1974806@rfd.leadboat.com>
 <4cea538c-def4-3f3e-7980-95497c33980e@dunslane.net>
 <20211205233238.GB1974806@rfd.leadboat.com>
 <9461cfff-5685-b46b-ac2e-17a67c59c836@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rjJXv+PXum3P92jt"
Content-Disposition: inline
In-Reply-To: <9461cfff-5685-b46b-ac2e-17a67c59c836@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/YbBpViH/EIJ2ZgBO%40paquier.xyz>
Precedence: bulk


--rjJXv+PXum3P92jt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 07, 2021 at 03:40:29PM -0500, Andrew Dunstan wrote:
> All done.

bowerbird is complaining here with the tests of pg_basebackup:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-12-08%2004%3A52%3A27

tar: Cannot execute remote shell: No such file or directory
tar: H\\:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_basebackup/tmp_check/t_010_pg_basebackup_main_data/backup/tarbackup2/base.tar:
Cannot open: I/O error
tar: Error is not recoverable: exiting now

This comes from init_from_backup() via the tar_command.  I am not sure
what to think about this error.  Perhaps this is related to the
environment.

+$ENV{TAR} ||= 'tar';
+$ENV{LZ4} ||= 'lz4';
+$ENV{GZIP_PROGRAM} ||= 'gzip';
This means that the default is to assume that those commands will be
always present, no?  But that may not be the case, which would cause
the tests of pg_basebackup to fail in 010_pg_basebackup.pl.  Shouldn't
we at least check that the command can be executed if defined and skip
the tests if not, in the same fashion as LZ4 and GZIP?
--
Michael

--rjJXv+PXum3P92jt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGwaVYACgkQnvQgOdby
QH1UBhAAmTLRh2Mrvw0SeNVZTnkekkU2+WQWG2t9x/behJJjF4xOp9qxdfPOc2p8
ShsGgtXtP01zdKJcyNFoBBAzpBfhbC4iwZrcrlpCY4FscvxdaVTGyXGwryIzhvJ9
Get0ep2A3bCvokkBMfRHA3352O9tJJQqqKMAUXr5xb8BereQ7f2v/SMBtWTSXoMT
Ez6L+X++EqBGiEMQIOQWISYRFg9ow0Oc3vAwNpo64vvaqg+Jk6Zf40RxGfTmrjhl
L+jXIDOA4vL+SCGMrz6aHQnko90XW78XfHXLnsvCp49aJp/UhMoKW7z/1/6TsAMt
HgRk1696xigPLeL7uYvQXVy+T4zpmMgtrPQ7Ns3o95InfUP6MhZ9vis+NVmDPRBl
aAzyxn+rCV/X4zhxxzO5NeZlb5ffMJpZ6xKO208EYRsnSBM8XneM4RgzyCz88hKG
8zUf9R8jWOqN2EhrlM5hi/ZEzwmO3FGX7IPzLkGvj6BtfsSjqT9m/yrgK/YLnsLw
4H1PGtBE8HbfA6IV2SYwwxwbiDHGZaMV7H/DFuK4DdBX1eEsTGwZBvWL6uGi6No/
XSl07CJjPeVLFQDjat/eI83we08dH96WjROGLQTWJEKGj2duCa4sctnCccJe5pBB
3T76KndGt1lkA++H8baSqxKWgqor2WAQIGnTt58CDHj59ppLMYc=
=kGEb
-----END PGP SIGNATURE-----

--rjJXv+PXum3P92jt--