Date: Fri, 24 Dec 2021 21:11:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bharath.rupireddyforpostgres@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Message-ID: <YcW5D2GjWlIzbbKs@paquier.xyz>
References: 
 <CALj2ACWt6kqriAHrO+AJj+OmP=suwbktHT5JoYAn-nqZe2gd2g@mail.gmail.com>
 <20211224.145134.1164706994861031206.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="khchaqLO/hmuNzaq"
Content-Disposition: inline
In-Reply-To: <20211224.145134.1164706994861031206.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YcW5D2GjWlIzbbKs%40paquier.xyz>
Precedence: bulk


--khchaqLO/hmuNzaq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 24, 2021 at 02:51:34PM +0900, Kyotaro Horiguchi wrote:
> I thougt about something like the following, but your proposal may be
> clearer.

+    "LSN=3D%X/%X, REDO LSN=3D%X/%X",
This could be rather confusing for the average user, even if I agree
that this is some information that only an advanced user could
understand.  Could it be possible to define those fields in a more
deterministic way?  For one, it is hard to understand the relationship
between both fields without looking at the code, particulary if both
share the same value.  It is at least rather..  Well, mostly, easy to
guess what each other field means in this context, which is not the
case of what you are proposing here.  One idea could be use also
"start point" for REDO, for example.=20
--
Michael

--khchaqLO/hmuNzaq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHFuQ8ACgkQnvQgOdby
QH2VpBAAqGYLbCo8OBzN8ZNZuNdBbfxbxXzpVEcNC4iqiLGsGeWGbls48uTsIElB
jah47dgD2q8wkwpo3lYQkhLmZffMzlbPCUzKIJPy2ZROme1V1YNnriZmbvtyFmY6
mclZz9iHZJjt1lQEkq3MGlyvMqzpSs0QUDduY0lMBDVHLTlqzE7MMcjCkCrDUK4U
Qy90cVzwi0VDjUzz4G4BX/kyDW3yjnfDH5R4zn53omzdX9XVoFxfpJ+gOTKcsDjx
OREk45NluVqF3H2oeNLnhqR8UIkITc364/WdgGffu76+8F7pbjmNuXrvO/nwKODy
5aQsf+OznBPWobdxOG4WN2yV55yAvAd2v0sBhzWXToKUuY2jSk2CrvLDll83FQZe
sK5Zb+HtZnw7JGbM/1Gnk1yVwHf5HBJ11CmzZhWbPI8kN/MF4uzgYzV6+fkaIA+1
LIO2VY6uNMj84c9XIxDXchoYZmCzGh//eWcMS252X8sLRIyT7EvlM/M+o3VDCj2H
+Z4GP6kTbnjqTJK23VmNKHEwvUMfU7DsZJiyjDwCDGEVcrThmqNbe3ra+3ZKAGgc
41DEtNn56Hv/iCbx9xesHEGK8eiNkl7w6FghsjPvg6QiB+csbf5bp2FXAAbwf5Op
dmH6+p2Jqd7MvUeOACbFHWmCrK7eCs9VoQgok/Ys7eVqh5hznG8=
=joJ6
-----END PGP SIGNATURE-----

--khchaqLO/hmuNzaq--