Date: Tue, 11 Jan 2022 16:57:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improve error handling of HMAC computations and SCRAM
Message-ID: <Yd04X0JHdfLgKVC+@paquier.xyz>
References: <Yd0N9tSAIIkFd+qi@paquier.xyz>
 <066c0624-fbb7-a025-afd6-d54683a96947@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="I7wdeyvqBxbYrPXa"
Content-Disposition: inline
In-Reply-To: <066c0624-fbb7-a025-afd6-d54683a96947@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/Yd04X0JHdfLgKVC%2B%40paquier.xyz>
Precedence: bulk


--I7wdeyvqBxbYrPXa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 11, 2022 at 10:50:50AM +0300, Sergey Shinderuk wrote:
> A few comments after a quick glance...

Thanks!

> + * Returns a static string providing errors about an error that happened
>=20
> "errors about an error" looks odd.

Sure, that could be reworded.  What about "providing details about an
error"?

> We already have SSLerrmessage elsewhere and it's documented to never retu=
rn
> NULL.  I find that confusing.

This name is chosen on purpose.  There could be some refactoring done
with those things.

> If I have two distinct pg_hmac_ctx's, are their errreason's idependent fr=
om
> one another or do they really point to the same static buffer?

Each errreason could be different, as each computation could fail for
a different reason.  If they fail for the same reason, they would
point to the same error context strings.
--
Michael

--I7wdeyvqBxbYrPXa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHdOF8ACgkQnvQgOdby
QH0ctRAAp89WN0m1D2AN75zxXxdSxYdfw6JhI9d/bhq/o9slCNC/nrCh+VvFwbPC
n81f+LrprzTBbZeRQwz0Pq3xCEN6FbQ4BsgGk3ynAdwTU5cEDHbzGnHhxkdE+fXs
nk8EP0U/6tRliuCDL20wZ41XrGnfOTfQny8AcQZYk5AV+aDu+rovJgoyms4SW6E1
U0gULUV28fVZ162xZsqqUF91qqHKkg6FnZVl8BEhSEGCNJYNFAPWz373aayla+Ji
GHWJ5y9DpAF2RIkoE+MIvQLvpf8jqaTUY45RefC/nN3N0Y04Hsk8QY1tyLEKyds/
fSauhtodyADFBTwgxcT7OlvZDa6NJzN6IUnAYdYblTy8C1zejwXaXpo2OysXCe4d
2WJ5uNUAv+KnAFbdgbRz0G5IPi33JXsFwUadTvt0ZxXPwmEVxrfl3/iHKSfJRZfl
KGZS0i0T2FPnajTPXCgHV65wk/caKg1jPPDb/tJjsIKevp5S+NQhwwFFsq6ZZ7hs
OxtiMfz05faD1L2IZKh95o/RLGoDPITvdFFeRxsOjB6xTnprahiRuhR8/blVg9Fu
Su3KLfxOngvqwcGIcl4raiNnV36484tZnTOxR1tORDuTF87CksUmBTQQGs0FXYbX
KeYmCEpFrSJJdiSox5hPCAYUGYWVFcmPaDpRtwsyUseHJGBaKD8=
=KGty
-----END PGP SIGNATURE-----

--I7wdeyvqBxbYrPXa--