public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Andres Freund <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: pg_upgrade verbosity when redirecting output to log file
Date: Mon, 10 Jan 2022 10:42:00 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Sun, Jan  9, 2022 at 10:39:58PM -0800, Andres Freund wrote:
> Hi,
> 
> On 2022-01-10 01:14:32 -0500, Tom Lane wrote:
> > Andres Freund <[email protected]> writes:
> > Fun!  That seems to me to be a strong argument for not letting
> > the behavior vary depending on isatty().
> 
> Yea.
> 
> 
> > I think I'd vote for just nuking that output altogether.
> > It seems of very dubious value.
> 
> It seems worthwhile in some form - on large cluster in copy mode, the "Copying
> user relation files" step can take *quite* a while, and even link/clone mode
> aren't fast. But perhaps what'd be really needed is something counting up
> actual progress in percentage of files and/or space...
> 
> I think just coupling it to verbose mode makes the most sense, for now?

All of this logging is from the stage where I was excited pg_upgrade
worked, and I wanted to give clear output if it failed in some way ---
printing the file names seems like an easy solution.  I agree at this
point that logging should be reduced, and if they want more logging, the
verbose option is the right way to get it.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_upgrade verbosity when redirecting output to log file
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox