Date: Mon, 24 Jan 2022 12:58:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Petr Jelinek <petr.jelinek@enterprisedb.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>,
	Kuntal Ghosh <kuntalghosh.2007@gmail.com>,
	"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [BUG]Update Toast data failure in logical replication
Message-ID: <Ye4j6oSeMDz3aPNs@paquier.xyz>
References: <CAA4eK1+k2TKPmdeZxgp2vgFtv2C8+dMKHR=-ty9HswDcCqkK6A@mail.gmail.com>
 <202108101438.bmmf4gqklowd@alvherre.pgsql>
 <CAA4eK1KgZr=QSBE_Qh0Qfb2ma1Tc6+ZxkMaUHO7aC7b9WSCRaw@mail.gmail.com>
 <CAFiTN-uW50w0tWoUBg_VYCdvNeCzT=t=JzhmiFd452FrLOwMMQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="XWuP3W59ctKFDhSB"
Content-Disposition: inline
In-Reply-To: <CAFiTN-uW50w0tWoUBg_VYCdvNeCzT=t=JzhmiFd452FrLOwMMQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Ye4j6oSeMDz3aPNs%40paquier.xyz>
Precedence: bulk


--XWuP3W59ctKFDhSB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 11, 2021 at 06:14:55PM +0530, Dilip Kumar wrote:
> Right

Amit, are you planning to look more at this patch?  It has been a
couple of months since the last update, and this is still a bug as far
as I understand.

FWIW, I find the API changes of HeapDetermineModifiedColumns() and
ExtractReplicaIdentity() a bit grotty.  Shouldn't we try to flatten
the old tuple instead?  There are things like
toast_flatten_tuple_to_datum() for this purpose if a tuple satisfies
HeapTupleHasExternal(), or just heap_copy_tuple_as_datum().
--
Michael

--XWuP3W59ctKFDhSB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHuI+oACgkQnvQgOdby
QH1EMxAAgMIgfYLmvicC7dbHFAyYk6iV339dgAdzn0REZzQKx/AfwlCK/m8XLeyQ
IScWp5gd32IbZ6N+sTLsOLM+Lua+lsZLmYusahDQkeDVmsNNYBkVXrJD+gs4f6fh
uNY2CF/Jo4QymYZXIkcbOqyADig+lt/i+aDDTL9sU+capxFA1CuBp+vqTLUT7BtS
WaDZ56SHWoPxZuu+Uhl3+LYFgEcf22w5MfmdluCGZHo2rYs4amxfuBsxDX1S4xzm
XeUqKFpReHdqDz2xDj0Nx5PPjPFoYheH84gdNNwvxMofvvO8QdKK1BYtgjNRE5nA
lID0m421jLKm4rcbto8B/GQwoHAjbGBmctAYss5H3xJdHYTZptiHBdp4dYSQUeKa
1Plvs6nMzzSQb8Z2/4QMd8/ryR7vAEK1bUQiaiW5R6G2/q6vaHN0PO9OMsaK8tzz
N8nHZKZfbiTDhm6f3ptEMynYJB0pGRwYvb3ooDmTYW0wZm6aklu8pLNZMCTCkQMM
bWfqT00QsY09uqOF6kgJ26GcOnfFBHjLHA1BAN+nuY1rLVdu1x9JhUe/lm1mthwf
eF4MnGGCDOFR47D96quhO6r63kFgdElAjum6JOHryjUdnf82rEHE3kPm8kHy92Ez
KIc0J4M6sr8eH9OcUW036mdQNqWQQC6LIdXsvxv2IUvmcr9UNlA=
=DlLQ
-----END PGP SIGNATURE-----

--XWuP3W59ctKFDhSB--