Date: Mon, 24 Jan 2022 16:01:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: typos
Message-ID: <Ye5O2zRtPoVbOEhV@paquier.xyz>
References: <20220124030001.GQ23027@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="UV4i2AV5JzeZit/c"
Content-Disposition: inline
In-Reply-To: <20220124030001.GQ23027@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Ye5O2zRtPoVbOEhV%40paquier.xyz>
Precedence: bulk


--UV4i2AV5JzeZit/c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 23, 2022 at 09:00:01PM -0600, Justin Pryzby wrote:
> Feel free to ignore this for now and revisit in April...

I don't mind fixing that now.  That means less to do later.

> @Michael: I'm not sure what this is trying to say.
> 1e9475694b0ae2cf1204d01d2ef6ad86f3c7cac8
> +      First, scan the directory where the WAL segment files are written =
and
> +      find the newest completed segment file, using as starting point the
> +      beginning of the next WAL segment file. This is calculated indepen=
dently
> +      on the compression method used to compress each segment.
>=20
> I suppose it should say independently *of* the compression method, but th=
en I
> still don't know what it means.  I checked FindStreamingStart().
> It that doesn't look like it's "calculated independently" - actually, it =
takes
> the compression method into account and explicitly handles each compressi=
on
> method.

This means that we are able to calculate the starting LSN even if the
segments stored use different compression methods or are
uncompressed.  Would you reword that differently?  Or perhaps removing
the last sentence of this paragraph would be simpler in the long run?
--
Michael

--UV4i2AV5JzeZit/c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHuTtsACgkQnvQgOdby
QH0HYA/+JU76IEVlyMWFeQFY0RPVk85UZbVH7NAADvZ7XdQmjwA6+yEo5MpoNzoZ
J6/BzyggV6NjkR1yHRZfcBUk49lzMv5a8i2l0BjdlezYajtW8Jv6YbrSZUm4wL9D
VEuaOHHOdRR3EYP1mzfGqLB67T1NyzOJllBpR1oPYomCdib1O2n76XWQW8sRgvRl
dDVayxCApP+AOsiyG8EPclW0P0AmEjB4IF2hOb/KYyIpIfzwG5rCEDGthYsEeCuG
DNWv4GECcFt/EcZjEja3K5Xd2I1MzuuKLgP/snfP2nWRYu/BcnCGqsfw8TGrupr0
feUYFHaVpobxz4J7DmTwxSSOesoYBdbUryuc6BOH6ry+T2gElMT+ryuwwGY0qyL/
EF1Gw+FYYYDM3xwQ7363i/vZlp9d+gTlsBz+Ow0ozwhmvxQDx0r8Pvtw18upl2wt
mhDLy5LJfZyUZAX6QByKXikJldpHbtNsG7bmv/1AqI5eVGeckoLpuQNd8PeLMmux
yht+2TP6d7l4cdUeh0MYY+Nk+zaGpaoBCVWi+IV205U0VdRdeBTAcI3N69kPCMOC
xVu6Lqtg5v/87x6v3EZOrhgmYNmurUiZ+H/BAYtzxHe+PiMTzZ9xe0jn5Khx5Ton
Y9m2U8krkK5Bw29sdKVBtNz6L5TOvTUOwZ8jwqepTxa6WQbjCD8=
=oFiT
-----END PGP SIGNATURE-----

--UV4i2AV5JzeZit/c--