Date: Sun, 6 Feb 2022 13:36:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Message-ID: <Yf9QN9jsIvzhhIsz@paquier.xyz>
References: <YefIHrNYTNH/PML4@paquier.xyz>
 <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
 <Yek+uQp/kMn2O3aK@paquier.xyz>
 <Ye4IDNnbMQ5IRxv9@paquier.xyz>
 <20220125164529.GG23027@telsasoft.com>
 <YfCZgF9iHVAL3MFr@paquier.xyz>
 <YfCrPHDuJ0rnmQR4@paquier.xyz>
 <YfPyt3fj7z2gVou9@paquier.xyz>
 <9f05b844-3a54-5883-9d3b-b5df12cbce88@dunslane.net>
 <YfSQBY88yRTRwjto@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iPAhj76XMKo9c/cZ"
Content-Disposition: inline
In-Reply-To: <YfSQBY88yRTRwjto@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Yf9QN9jsIvzhhIsz%40paquier.xyz>
Precedence: bulk


--iPAhj76XMKo9c/cZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 29, 2022 at 09:53:25AM +0900, Michael Paquier wrote:
> On Fri, Jan 28, 2022 at 06:27:29PM -0500, Andrew Dunstan wrote:
>> I have committed this. But it will take time to get every buildfarm own
>> to upgrade.
>=20
> Thanks for that.

So, it took me some time to get back to this thread, and looked at it
for the last couple of days...  The buildfarm client v14 has been
released on the 29th of January, which means that we are good to go.

I have found one issue while reviewing things: the creation of the new
subdirectory and its contents should satisfy group permissions for the
new cluster's data folder, but we were not doing that properly as we
called GetDataDirectoryCreatePerm() after make_outputdirs() so we
missed the proper values for create_mode and umask().  The rest looked
fine, and I got a green CI run on my own repo.  Hence, applied.

I'll keep an eye on the buildfarm, in case.
--
Michael

--iPAhj76XMKo9c/cZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmH/UDcACgkQnvQgOdby
QH0rnQ//fW2Rh41y/HiiY0JdjqQThn6Lz1LBkRfH67hp9bl1vrTRNPcgdTxueEAB
g8tXVeY6lf0NxpcKWeZhNCOzVTCL33uGylMF11YMr9STAbkPLlG4KSiuWHHSgPsX
yG9T8KZb2MgMD5dA1BLuZC4QeIAU/3jc9QyrkCOI2gNPXO7rH4d8fLrWWIgT+ewm
IyDmotJhCJ2NMiur+zCQox0VWBUrrcVFDjgvHPXOECiuP94sgYmr2zmE7FgUimbk
4LzwOA9d4QN7yrpd5/Od+z9w+iB13u1/dcK98NLYf5FsVugZdlpSVEcTnUjzCGp0
TmYcuYF97iN5NSbewodLL989H666/ZFfNsaaolrNLlKJ+0LA9qxf7LV7eOqo0CXF
Iy79i8tX5F0+XMv5aDRDlWIdq09FleZwJTFE0lUPECJ9WK6Fy8Ij8D70fgmckxlc
yR0oC2bssGoa7mY3H+ZeuhtTxju1ElOwR+a05O8KMtzWs+VsTfNCyX2wWp69wdsQ
nBNNU04/nQGwXDcb2G+lwB4ZK8mVFB4b8KFzabxKnQ4Q+Exu1gpPbtcYggA5YkDM
ArsZLbuHkDr8K+EFmyCsDbfp4tler/Im/iZdR+Dd5thzwa96MuokZeaDFeBUuQHQ
ivbMRuZMy19kIwpE3LcifiV0iCFquybXxkrZnyZeMGswGPblXkE=
=jK6p
-----END PGP SIGNATURE-----

--iPAhj76XMKo9c/cZ--