Date: Sun, 6 Feb 2022 15:11:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Message-ID: <Yf9moK14gjWedzzo@paquier.xyz>
References: <Yek+uQp/kMn2O3aK@paquier.xyz>
 <Ye4IDNnbMQ5IRxv9@paquier.xyz>
 <20220125164529.GG23027@telsasoft.com>
 <YfCZgF9iHVAL3MFr@paquier.xyz>
 <YfCrPHDuJ0rnmQR4@paquier.xyz>
 <YfPyt3fj7z2gVou9@paquier.xyz>
 <9f05b844-3a54-5883-9d3b-b5df12cbce88@dunslane.net>
 <YfSQBY88yRTRwjto@paquier.xyz>
 <Yf9QN9jsIvzhhIsz@paquier.xyz>
 <20220206060344.seyr776u67mqjyn6@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DmviTBsrxuEqjdDF"
Content-Disposition: inline
In-Reply-To: <20220206060344.seyr776u67mqjyn6@jrouhaud>
Archived-At: 
 <https://www.postgresql.org/message-id/Yf9moK14gjWedzzo%40paquier.xyz>
Precedence: bulk


--DmviTBsrxuEqjdDF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Feb 06, 2022 at 02:03:44PM +0800, Julien Rouhaud wrote:
> I didn't follow that thread closely, but if having the latest buildfarm client
> version installed is a hard requirement this will likely be a problem.  First,
> there was no email to warn buildfarm owners that a new version is available,
> and even if there was I doubt that every owner would have updated it since.
> Especially since this is the lunar new year period, so at least 2 buildfarm
> owners (me included) are on holidays since last week.

The buildfarm will still be able to work as it did so that's not a
hard requirement per-se.  The only thing changing is that we would not
find the logs in the event of a failure in the tests of pg_upgrade,
and the buildfarm client is coded to never fail if it does not see
logs in some of the paths it looks at, it just holds the full history
of the paths we have used across the ages.
--
Michael

--DmviTBsrxuEqjdDF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmH/ZqAACgkQnvQgOdby
QH0MRA/+PjRAOICVHjvnvmzfPDO5fhQsNRo4RO8AStJ0lz5Ls3B4jNQ5ZvdzayyR
eEQ9nON9njNeX/hR32D/LaeixelaS0q2IoEl1iCl77dXgVNRqbHhdxkpnqyzqsEY
a9kDTZvjuFf8nUCB79P3QuiRWnsf5BYu5zbkFgfoJd8S8YaYSToTCKu5lpAE3/BV
jOvAoMtYqd3rM8eQrj6+p4lqHwZb4Cpy4zXttlrkrXRxYlGbP0R33rAE2TR8Sb8q
HpLm0sOd2rhuc+sJn4rJ0G5hVffvgPD9zpOGEELe17rw1cPipzDYKZvnsBZ8vuW+
1FwQ4JqiZIrbpu6hk7WCF8BPJ+oI86t4yDffyA0uW44TbruOdueJ5YFQfKdxymxC
06ORUtgo8S8hlChZoNF3zQQuBSgKXpa4TyHzzaexgXT1uA0gm555sRe6cIfX5f7U
CtgQj6XVc1LK78SlzV8Vv9sUR8GuPzusqi6dOf/rXdGf2qhXL1g103k2j41odn+1
i2U5dB0IUvYyNwPimPF/lGIpoOU72l519Ry/iySec8yIAFOY48HY1MnqaTIoXKrR
FnABr6whE4pRcDr30t4f3Ch+G5/SCFDJPMcgXHVzyt92rLKLK/DWxeNDuo986RLb
NbFC/9YUvymhKuo3pjL45c+jXoOcAtFjyNzQb1K07s0+30WrfGE=
=qUmq
-----END PGP SIGNATURE-----

--DmviTBsrxuEqjdDF--