Date: Wed, 26 Jan 2022 10:29:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Dipesh Pandit <dipesh.pandit@gmail.com>,
	Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: refactoring basebackup.c
Message-ID: <YfCj+QFS6hKlcscJ@paquier.xyz>
References: 
 <CAOgcT0N+Nwjx1M_ZP9vr7P_gX9ftMjNrsK6JSYRawdjvTQ7k5A@mail.gmail.com>
 <b9a7a67e-d71a-6d0c-cc59-0ae63e2b2040@enterprisedb.com>
 <CAOgcT0NH+DRkj6pr51DsYyPg73Fuj-uLpr707akfZcbaxTqdvQ@mail.gmail.com>
 <CAC6VRoYRJkzRxU_TVG7PMGMn5+Eb-VSOiO+mVaj2WUyeF9DpkA@mail.gmail.com>
 <CAOgcT0NBurXSm+ZeF=PiBcAm9mywHFo6Jc9G+F7JFU8O9sndBQ@mail.gmail.com>
 <CA+TgmoZ5_j+ZLf66_EioReGXvYTCkgQZju9SDq8yg_QbY_1vTw@mail.gmail.com>
 <CAN1g5_FSqShfWKibkCrJr45hHtRCBQUUtGVEHn4wNv=YCkybtQ@mail.gmail.com>
 <CA+TgmobQYkP81QQgS6tvvt4cRxvmipHQ4eU-aNjSpiZJhdkckA@mail.gmail.com>
 <CA+Tgmoa-ST7fMLsVJduOB7Eub=2WjfpHS+QxHVEpUoinf4bOSg@mail.gmail.com>
 <f7b38b10-2ead-1810-b4d2-8fceab32d431@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gh9tcT4vUIxEd3yV"
Content-Disposition: inline
In-Reply-To: <f7b38b10-2ead-1810-b4d2-8fceab32d431@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YfCj%2BQFS6hKlcscJ%40paquier.xyz>
Precedence: bulk


--gh9tcT4vUIxEd3yV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 25, 2022 at 09:52:12PM +0530, tushar wrote:
> C) -R option is silently ignoring
>=20
> go to /tmp/pp folder and extract it - there is no "standby.signal" file a=
nd
> if we start cluster against this data directory,it will not be in slave
> mode.

Yeah, I don't think it's good to silently ignore the option, and we
should not generate the file on the server-side.  Rather than erroring
in this case, you'd better add the file to the existing compressed
file of the base data folder on the client-side.

This makes me wonder whether we should begin tracking any open items
for v15..  We don't want to lose track of any issue with features
committed already in the tree.
--
Michael

--gh9tcT4vUIxEd3yV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHwo/kACgkQnvQgOdby
QH3UbRAAiwKGjqNA7lU0D3nTmFG4N2+RHvdHxXXT9zAJCUSxS0K9pW7Lp8QRUj8F
Iau1WOABaXv6blo0FfQcrqiekMTwhJXF9S12bQRQLrDHrhYhqk8b3yuBofNDRhC4
YL1FFtDw6vYBBsM28vy8rG8y6UKBaciZD9Z5Ux2Utao4KtxLbqRTo0M4vJJz6bL2
QvizLyqlLYEFh38NPFBIcAJ4ZvwI2YKoDooOML7TzTnhYOuLdOHn7JbyPcVvRABZ
ujRYW6VmxDNLCUhwAfRw6FO7mNhBBS0lQIaLnB40u43VeOoUfWaYW1NCP+yKi33P
eLi+b8bDL4WTs5k73vSUXA/eO3WaOmEsZvUX8FdJizzzF5kdZVyu5ND2mFiIaY0Y
H0Vt2bDZtpJ/Brgxi/aCdPjXyHWPD9jvAXJdOBr/JBK+mFeo+jZZ3uRY7cNvmoWD
NcVT2KQWfB061/KoJRoz77wsWCxcg4DbrSwJNgeua3kruRIXoA6QwqRn31nbGv0Q
r4epZlMMm42sQX89SxdlEVVpNn1i0mGFUOecYdn2n6/RcLoYJ0bizl6FUvIKq8Ju
mMx7WBKIxBp6wH/13wo4taBK4DTY2xaQLDDLoZR9BNmUyrNGFI1gUhb4IKByMbgS
ThpAKV+2t0Kuk1wU/I9Vqk8pHglU2ziulz28SsQC+dRUR7Wp6P0=
=UdT8
-----END PGP SIGNATURE-----

--gh9tcT4vUIxEd3yV--