public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Ranier Vilela <[email protected]>
Cc: David Zhang <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Mahendra Singh Thalor <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
Date: Thu, 27 Jan 2022 16:32:28 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEudQAoOGkfAczUjtHGU0=3z_2+F76zh6_NVvsVngRKbzqJiQg@mail.gmail.com>
References: <CAKYtNAoUu1_jizdzP1qF7anW=ijN6MsP1eFPB7Qy7k4EL+x6UA@mail.gmail.com>
	<CAEudQApTd4w8vHOgZAfgFeCNoes-hgc6BhwHHXqDS=K3Orm-Uw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEudQAoOGkfAczUjtHGU0=3z_2+F76zh6_NVvsVngRKbzqJiQg@mail.gmail.com>

On Fri, Oct 01, 2021 at 05:03:04PM -0300, Ranier Vilela wrote:
> For me the assertion remains valid and usable.

Well, I was looking at this thread again, and I still don't see what
we benefit from this change.  One thing that could also be done is to
initialize "result" at {0} at the top of FreePageManagerGetInternal()
and FreePageManagerPutInternal(), but that's in the same category as
the other suggestions.  I'll go drop the patch if there are no
objections.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox