Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDRWJ-000167-04 for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Jan 2022 13:42:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nDRWH-00033c-Oa for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Jan 2022 13:42:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDRWF-00033N-B8 for pgsql-hackers@lists.postgresql.org; Fri, 28 Jan 2022 13:42:29 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDRWC-0006eX-Hu for pgsql-hackers@lists.postgresql.org; Fri, 28 Jan 2022 13:42:26 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DF9A232009E5; Fri, 28 Jan 2022 08:42:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 28 Jan 2022 08:42:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=i0x+ZuUBkEgNy0etk1DZkCxBvV6w/GmVWasSW7 LqzPw=; b=EDtHmxOHa51Had3mmBCPPyX0k/WRn+r9mmBVM/jsgQH2EN0qoHzArM HC3Ex/prtxbb5rDATOSnFVu+sQYkXVVkW+lfM1gXyXNFMrwACTdzwQMAyUhEFI3r gLzqBRBkPLSIAw5Vl0jd7TNBHB3Y8EbPt4oy1txERGQaTCXTag+FCMbCycqOA5Bk NUpsCNPg8rtvcLXVQVLsBYtbHi3W7jqKxI2l8baWQMwMRScDbnX+oJNl3M580H+F jmnupkrczRmvkI7w2EYANYjsaMqu+La3ycqvsukKjVrEu8RMb+Obwwmd0HGMcYvR bL0ytc+b3OjZ7wlVjLNoWvXpDix2xhug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=i0x+ZuUBkEgNy0etk 1DZkCxBvV6w/GmVWasSW7LqzPw=; b=Dw8rAemgJLqCEeT0L2tZ0+JeLCRXecK+I npudOWQ7PKA9tidFBy6US7dMwwytkya4mh11zn3VmSXBAFETz4ms0JsQeCnUd/xo qZa40+j16r7Z5Szdtr6sLYYKExPBVbyJvFBROxMdzgY1H7jTyO1sgCLCk5Q90tKa cIx1TDyI7+OyxcuJIN4JlQzRER3YHt85DFzXgLv9IScgvIEdP2g0fZAf0RhmYLWd Wawz95wlSaZNPJB5MwMttSycIlkmnI3+o+OpKqu29Afic7cWn+M9Of0+1KNyXJTj cBB8yjSgBWV0b9hjR8H45t6O61XEj2J7iJCIL2t2Aex/I58vk5QSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfeehgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jan 2022 08:42:18 -0500 (EST) Date: Fri, 28 Jan 2022 22:42:15 +0900 From: Michael Paquier To: Justin Pryzby Cc: Peter Eisentraut , Tom Lane , Daniel Gustafsson , Andrew Dunstan , Bruce Momjian , pgsql-hackers@lists.postgresql.org Subject: Re: pg_upgrade should truncate/remove its logs before running Message-ID: References: <20220111200307.GA14051@telsasoft.com> <20220112040813.GD14051@telsasoft.com> <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com> <20220125164529.GG23027@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HqR+0G48cVT/s19V" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --HqR+0G48cVT/s19V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 26, 2022 at 11:00:28AM +0900, Michael Paquier wrote: > Bleh. This would point to the old data directory, so this needs to be > "$self->{pgsql}/src/bin/pg_upgrade/tmp_check/data/pg_upgrade_output.d/log/*.log" > to point to the upgraded cluster. Please note that I have sent a patch to merge this change in the buildfarm code. Comments are welcome. -- Michael --HqR+0G48cVT/s19V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmHz8rcACgkQnvQgOdby QH1bpQ//Vnd2+boeskJRX4YDI4d3gWwWvlk8HRSvTf1hoTMh0r184n12sUYMFE+o hnu0xpXPc/SAecMe5my47EH5k3gfFc6hTpwnHtteFNr0rOMM/Ib1BJIf8GYrc4aJ Cw6ZIod6FPSM/7pvnlPrY2zU9K0PzTS7txq8BUzAsa446a1SCliv9/Fp1ccqgHzK IzB6YawNuB53guW0MaXvRGvpEuSUL+PLJSzj0mZ0XqZZo0tVXtg2ziRQgCsMs/EL 8L2BIwfXQ6yWpma7wanCcmcQQGV4Nnu1d+19PD2lXBRFJwxx5Lt3IKLK70Jv6lko EQybQCw7AA21QN8MP41iA29ekCOX+MVy/54jGmmjC68OsXH94KweuYGZ+TCwvBq0 b6lMqE22UHMkULShjRE9Eq39zus0nKpYwRHjkNmzDpJ1wowZ4ymeSiEUhrnmNuCa NYkD9t2Ziwrcbm+mK5SZYJMGZu740Sr4vL5h7v8RwY0qZib6tQW+WafGZBxVOt+L 4eOIrLkQnsa+aXbXmnjxT5RF/FxhthiMVV5WmzyBKDMEPgmIDLYh86Wn01VSUH3Z JKQ+mMEOgM5G2rDr5VSazjyRQKKB2JpJ/FU/UNF6DhUGAVblks31Xc1Xe/7G9tQ5 kFgowOZda1qqVoD4YribKecDJO6N2tFUdvi1os+TJd/lKwgGJoQ= =2bNA -----END PGP SIGNATURE----- --HqR+0G48cVT/s19V--