public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jaime Casanova <[email protected]>
To: Julien Rouhaud <[email protected]>
Cc: Greg Stark <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: 2022-01 Commitfest
Date: Wed, 2 Feb 2022 12:45:40 -0500
Message-ID: <YfrDRHq/kmiiMj2k@ahch-to> (raw)
In-Reply-To: <20220202172853.64yxtit33vppswdl@jrouhaud>
References: <20220112054142.u3ha2hky7r76vxq7@jrouhaud>
<20220117153843.4qoevdgab3xycopb@jrouhaud>
<20220125031445.rm53piwl7yipgqqs@jrouhaud>
<20220202161519.5owvpmckw2bb5kg2@jrouhaud>
<CAM-w4HMcY7_7ab1QDofSZY0DBGj0SPmZwULkxgjAwqcSXNJObA@mail.gmail.com>
<20220202172853.64yxtit33vppswdl@jrouhaud>
On Thu, Feb 03, 2022 at 01:28:53AM +0800, Julien Rouhaud wrote:
>
> My understanding of "Returned with Feedback" is that the patch implements
> something wanted, but as proposed won't be accepted without a major redesign or
> something like that. Not patches that are going through normal "review /
> addressing reviews" cycles. And definitely not bug fixes either.
>
> If we close all patches that had a review just because they weren't perfect in
> their initial submission, we're just going to force everyone to re-register
> their patch for every single commit fest. I don't see that doing anything
> apart from making sure that everyone stops contributing.
>
I had the same problem last time, "Returned with feedback" didn't feel
fine in some cases.
After reading this i started to wish there was some kind of guide about
this, and of course the wiki has that guide (outdated yes but something
to start with).
https://wiki.postgresql.org/wiki/CommitFest_Checklist#Sudden_Death_Overtime
This needs some love, still mentions rrreviewers for example, but if we
updated and put here a clear definition of the states maybe it could
help to do CF managment.
--
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: 2022-01 Commitfest
In-Reply-To: <YfrDRHq/kmiiMj2k@ahch-to>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox