Date: Mon, 14 Feb 2022 15:31:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha <juanjo.santamaria@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_receivewal.exe unhandled exception in zlib1.dll
Message-ID: <Ygn3TqQM3DpnaX5Z@paquier.xyz>
References: <CAC+AXB1iY4pM=o55OBuUy30LmUo5hjY83=TcA-NgY3CGZpzJmA@mail.gmail.com>
 <20220211155044.x75ziw7cvbb5p23h@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jmHKxST/3pmM87JZ"
Content-Disposition: inline
In-Reply-To: <20220211155044.x75ziw7cvbb5p23h@alap3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/Ygn3TqQM3DpnaX5Z%40paquier.xyz>
Precedence: bulk


--jmHKxST/3pmM87JZ
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 11, 2022 at 07:50:44AM -0800, Andres Freund wrote:
> On 2022-02-11 16:33:11 +0100, Juan Jos=E9 Santamar=EDa Flecha wrote:
>> The problem comes from the file descriptor passed to gzdopen() in
>> 'src/bin/pg_basebackup/walmethods.c'. Using gzopen() instead, solves the
>> issue without ifdefing for WIN32. Please find attached a patch for so.

This looks wrong to me as gzclose() would close() the file descriptor
we pass in via gzdopen(), and some code paths of walmethods.c rely on
this assumption so this would leak fds on repeated errors.

> I hit this as well. The problem is really caused by using a debug build of
> postgres vs a production build of zlib. The use different C runtimes, with
> different file descriptors. A lot of resources in the windows world are
> unfortunately tied to the C runtime and that there can multiple C runtime=
s in
> a single process.

It may be worth warning about that at build time, or just document the
matter perhaps?  I don't recall seeing any MSIs related to zlib that
have compile with the debug options.
--
Michael

--jmHKxST/3pmM87JZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIJ904ACgkQnvQgOdby
QH2b8Q//R9GXF+HAltu0dDDrrUX1OpdjjFrNIAdgXiFCuag+iIrmJXBHvfQT0H6g
hVarGWbMyM1RPv3UEg5Lb5/lUvTj7t7RuwAsKiNR4w/0qdPoZP7cuZK0qEw31TL7
L+RtUUH8B7qCL6LsEVmimmF8cj/GjWXf4isd1+kbDs8LmVz5+P5CGjidNK4znD+E
LDEA0fpgR69IdU1nQb5NAMORZE8H2bRbdpxakvk7hZkRLXG0Fk4aekJ/+ndATPQu
CDgRYESZNhlEmBvV+fFMOjOr1pBucCKgHUlfOEOrtPav/58x2sq6Qgiuw/lAjEVj
11X30iu4C7AXzCs/sE2Y6IKgineyDR67edsA4tnUTV9Vs3LKbBaR04di6YvtdVc4
zd0KFEChNaK0UGwkO801fvE/StrtOX4LgFkMmNGX0sIM3xamXeuRnQ0Qhu/N7/Cp
NaCASDQ7ViJHk6YbF0FJGlIhWNplVCLQGg/pHpCqlhv3Ky+VsA+ZdUw+ceVGbEgQ
eWZ+IjV6CuHE1nEvVVp+62gfc2GB0x/qmkMvBWZvZShv1GDKkmN/DY75siWkA+6s
a0DZbFwcQaV9U5oAnxJvZ8YqB/+7Vjw3pmZmyyCnv+sO04oj6tFxz+HG3F8laSyW
5fc3DwRFxXDoGgsTDiOx/gNIndzrtVA9JDMR8AbBcqN3l4y5Jrs=
=As7A
-----END PGP SIGNATURE-----

--jmHKxST/3pmM87JZ--