Date: Mon, 14 Feb 2022 17:01:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
Message-ID: <YgoMQQgZrQihu/+C@paquier.xyz>
References: <20211214020824.azjrighbeucby5yc@alap3.anarazel.de>
 <YbgsLG0q4n9f0JBE@paquier.xyz>
 <20211214061449.ynrygtcddn3ujunn@alap3.anarazel.de>
 <YblJLJKUZYI4Pqbq@paquier.xyz>
 <Ybqpy4nS6bMq5Qud@paquier.xyz>
 <YdVS+X4SNXO93Oib@paquier.xyz>
 <Yd0uUcGyYJrEPshD@paquier.xyz>
 <20220115055239.6i5mp7ujtcpto2mg@jrouhaud>
 <YeYj4DU5qY/rtKXT@paquier.xyz>
 <20220213041242.xhpixy3kwwmswkfk@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VlRgIPhI8OlLo0la"
Content-Disposition: inline
In-Reply-To: <20220213041242.xhpixy3kwwmswkfk@alap3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/YgoMQQgZrQihu/%2BC%40paquier.xyz>
Precedence: bulk


--VlRgIPhI8OlLo0la
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 12, 2022 at 08:12:42PM -0800, Andres Freund wrote:
> It also doesn't handle @ correctly. Makes sense to fix. Should probably u=
se
> the same logic that libpq, psql, ... use?
>=20
> 			if (is_unixsock_path(ch->host))
> 				ch->type =3D CHT_UNIX_SOCKET;
>=20
> that'd basically be the same amount of code. And easier to understand.

So, I am catching up with some parts of this thread, and I have
managed to miss is_unixsock_path().  Except if I am missing something
(now it is close to the end of the day here), a minimal change would
be something like that as we'd still want to allow the use of
localhost and others:
    if (value && strlen(value) > 0 &&
    /* check for 'local' host values */
        (strcmp(value, "localhost") !=3D 0 && strcmp(value, "127.0.0.1") !=
=3D 0 &&
-        strcmp(value, "::1") !=3D 0 && value[0] !=3D '/'))
+        strcmp(value, "::1") !=3D 0 && !is_unixsock_path(value)))

Or perhaps we should restrict more the use of localhost values for
non-WIN32?  Opinions?
--
Michael

--VlRgIPhI8OlLo0la
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIKDEEACgkQnvQgOdby
QH1ePQ/9G4sMoyx+O4CN31k+Sy/Zn1QTfDpJzUMGVU3WF1K83b2/jwQ6wAOagYSD
utv0infjm4v7PDyR2TkYG19Xx2tBOlPlGex5AFoyIBkCh0C0A1fkjRiZADp1By5h
gZbHyBmZ+fJFyMF7A71M5uQsrUcu3bIYqfuasOAZ/ZHmS8Yv+xwX5ZKhJbT3wjaL
BMdITKdoub5fsBb7D/McjvMs2oAD3rAVp7TOy/d9/xMAQWB4oQ2w3XxszlU3iUWk
HSWBebKrji7tDfBdd9XeXQoKNzIP1IqreZfkbGS8MvRdwpgww86W014ogvf50/iE
SJZb/gbXvHljI6pYD9t1is+cIfL9JCwMlytqd4Emk74dwZ3QxxplrmM5IIYuWjSX
GjA77Ni2bi7a5R1gPINQhIwu/eQjaH9LLTqO53lPax3fXlKkp4yGbbOdv7lKSBlf
cfU80e8YtaE3r9zGAU1nGui8s810mhq58YyIcIo+bsZjjYV21G7f8p0ReyYPsS7w
gwxOEf8Elv5RXQQvzRVyVv6wJQv+EzmzFOX8OPtEh3/eql83jRMdlz9F2E71ycT4
uSv5ysp8R+y0KCG4UxYatppigAziRuN0aVzQ8jVboyJjytRZ5nU11+ZHphPdS3qM
Wt5fvlWg8FOYlfjwV19KbwstWrEdPJXBeWcGHMuf44nlVoMTcoY=
=J8Vy
-----END PGP SIGNATURE-----

--VlRgIPhI8OlLo0la--