Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJgQO-0006Cp-NW for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 18:50:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJgQL-0008SJ-Vt for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Feb 2022 18:50:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJgQL-0008SA-IJ for pgsql-hackers@lists.postgresql.org; Mon, 14 Feb 2022 18:50:09 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJgQE-0007v1-FC for pgsql-hackers@postgresql.org; Mon, 14 Feb 2022 18:50:08 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1477:7740:df3c:d202:ca71:8aa5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4JyCvW6j6pz3Dyq; Mon, 14 Feb 2022 19:49:59 +0100 (CET) Date: Mon, 14 Feb 2022 19:49:59 +0100 From: Christoph Berg To: Peter Eisentraut Cc: pgsql-hackers Subject: Re: Non-decimal integer literals Message-ID: Mail-Followup-To: Christoph Berg , Peter Eisentraut , pgsql-hackers References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Peter Eisentraut > This adds support in the lexer as well as in the integer type input > functions. > > Those core parts are straightforward enough, but there are a bunch of other > places where integers are parsed, and one could consider in each case > whether they should get the same treatment, for example the replication > syntax lexer, or input function for oid, numeric, and int2vector. One thing I always found weird is that timeline IDs appear most prominently as hex numbers in WAL filenames, but they are printed as decimal in the log ("new timeline id nn"), and have to be specified as decimal in recovery_target_timeline. Perhaps both these could make use of 0xhex numbers as well. Christoph