Date: Mon, 21 Feb 2022 10:02:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add support for building with ZSTD.
Message-ID: <YhLkwodatZTnoHO4@paquier.xyz>
References: <E1nL8NS-0007eH-9y@gemulon.postgresql.org>
 <YhCL0fKnDv/Zvtuo@paquier.xyz>
 <CA+TgmoZLtMURjevDpzGQyW46GUdTJNRemNujxkBQR_KMuOTKMg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wpKeYMokTb/uVQ2D"
Content-Disposition: inline
In-Reply-To: <CA+TgmoZLtMURjevDpzGQyW46GUdTJNRemNujxkBQR_KMuOTKMg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/YhLkwodatZTnoHO4%40paquier.xyz>
Precedence: bulk


--wpKeYMokTb/uVQ2D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Feb 20, 2022 at 09:45:05AM -0500, Robert Haas wrote:
> No issues at all with you adjusting this, but I think that sentence
> reads a little awkwardly.

Thanks.

> Perhaps instead of "The default is
> <literal>zstd</literal>, that would be the command found in
> <varname>PATH</varname>." you could write something like "The default
> is <literal>zstd</literal>, which will search for a command by that
> name in the configured <varname>PATH</varname>." Or maybe something
> else is better, not sure exactly, your version just seems a little odd
> to me.

Okay, done then.  We've been using the same wording for all the other
variables, and what you are suggesting here sounds much better to me,
so I have adjusted all the descriptions this way, and added the ZSTD
part.
--
Michael

--wpKeYMokTb/uVQ2D
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIS5MIACgkQnvQgOdby
QH2Egw//fR1yVHNFrki3jzUyn9NN3kcBUkhUwP18IMxHjh3RLP2gnZfqVXT78rlJ
EQchO4kyi8CQZQ3Nu/kjqmUCvGB9JVAJSzQggazefB2f/rqpA9zV8mDSnCfswALc
sn4ViM/GdtqCawg41R1gdaUVff3FsvQNfWayDZnSsBeB4L/mg2K1mfaG9msDofZT
zzBaEtILNiPOEIcC0FwT3EriSR5VFq9/DZtnZ12WeVz0uI0SQEDVlbvu7zgv0GnU
UIE/88W5A71yi3mPO3x3Qqfs/MvpkRCOJs5H4do/s/oJIFGibjhblLZvNhmnuG4F
aLGdhqYuC1DAskZNLRO0LJiL+sROiyAvyhfNTdsNHbHJHNfu82Jcu8Tdv1Pt5box
gtQ5CJ/msQr9w7ZpC8T0/Frj2hYkUjoLysE4ajcJlGDn4SGgfAySgz9/VwaMvnj/
nYevBoUCxXG1AjalLm6gpWuRcjlJqELScparuT7/2TlbKBSgmcylTmFZIW8MFHoR
alVAjmJ5qeD4qTnqFNl9oAJQ5yixfmXKv8YtEuJLDZ5TK4xSdTkHPEpB4FxGDfVp
WH2H/TaoBXyKfLY7VmsphmmP55dHtjAz2fuZsQvVKkGxmqTNli+A4kdlIijPmFLj
A8WbM5A0G0oDAFYMmA5FNZNeT0wfJIHqKdYWlQvAHTTC8rXwgYE=
=LaLI
-----END PGP SIGNATURE-----

--wpKeYMokTb/uVQ2D--