Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nM3gy-0005CD-I3 for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Feb 2022 08:05:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nM3gw-0006cn-SJ for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Feb 2022 08:05:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nM3gw-0006ce-Io for pgsql-hackers@lists.postgresql.org; Mon, 21 Feb 2022 08:05:06 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nM3gt-0004jD-63 for pgsql-hackers@postgresql.org; Mon, 21 Feb 2022 08:05:06 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id BFD0A3200B8B; Mon, 21 Feb 2022 03:04:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 21 Feb 2022 03:04:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=3cIXQFLWgDXE/WCPHw0keEJJnPO/0CBrhM70y3 7ygEc=; b=ekb7jksiYyXiLYf7kM8OIU3nkE71E9i3gTyI+akYj9NohF9nQxZ2oE 9Y+Beb4VjSy+FC+uH8ihLC0YCXmxB1N7VVRfYIu5oH2+UWPvTWEAUttQThu51lOe BPTyFQBj1Z0W6uftDFjDyjB5rzjTLzfYZelQnmVpfYsWUmvgSPM4dtryPgE9LDmZ xG0puwsbTX8tlRG5/pW0FfBT6hZF6AKHQHaBQALhqKPs7eU1Rb44W/hV3erWwmTS p2XonazEOPtj7j/FahWe2ZkqkgidGTx4tVklRatkFBpYIBm3libN6USOKdJV9eEq W+SQxbx9SPcyqPKx2BLfuD2i7OztzUgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3cIXQFLWgDXE/WCPH w0keEJJnPO/0CBrhM70y37ygEc=; b=MgMbFweAdPuNkuCNnAN1YvQeasQpDIu12 lSqvIoeIr2vOdjk3JuZAvoqGbMomdRSTpW6b8Lu/ARe2JUqBcBgAy4v9ySacNfqL 0m59/nOCxIEQe1MOR9r93JLJ4VHq7VUYZgufupMxoKLeqn6BNEfEFNfbYiSvi/9V 9x+epKq+Ucms69lPU8BAn5slHdt2feUzyN4WieF0SCZF0HNsjm0AzreGbw1e01l5 zzMFBLjh5zz2qNXheKvucpRA+JKYmB1rQ/2u4IxYS03QnAObfnk95JEB6Ns3gmWd aL+SXYrLYgqzs73+RZ9LBybigUJ9kvwNOVeLN9PwJl/TmRe+zvW8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeehgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudeffeelgffhkedukeekvedv udfgieetkeekudelfeevhffhffdtudffieeutdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 03:04:55 -0500 (EST) Date: Mon, 21 Feb 2022 17:04:51 +0900 From: Michael Paquier To: Alexander Lakhin Cc: Justin Pryzby , Daria Lepikhova , pgsql-hackers@postgresql.org Subject: Re: Assert in pageinspect with NULL pages Message-ID: References: <561e187b-3549-c8d5-03f5-525c14e65bd0@postgrespro.ru> <20220218030020.GA1137@telsasoft.com> <150535d6-65ac-16ee-b28a-851965fc485b@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="glnNGM8IU/6FdpHW" Content-Disposition: inline In-Reply-To: <150535d6-65ac-16ee-b28a-851965fc485b@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --glnNGM8IU/6FdpHW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 21, 2022 at 10:00:00AM +0300, Alexander Lakhin wrote: > Could you please confirm before committing the patchset that it fixes > the bug #16527 [1]? Or maybe I could check it? > (Original patch proposed by Daria doesn't cover that case, but if the > patch going to be improved, probably it's worth fixing that bug too.) I have not directly checked, but that looks like the same issue to me. By the way, I was waiting for an updated patch set, based on the review provided upthread: https://www.postgresql.org/message-id/Yg8MPrV49/9Usqs1@paquier.xyz And it seems better to group everything in a single commit as the same areas are touched. -- Michael --glnNGM8IU/6FdpHW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmITR6MACgkQnvQgOdby QH02qRAAn/bAv7nGmSK+cttzn7RjOPshLczMY8n7lNRX5ZeynCzvWAL6srRJT+OP Udh5GUfsiMAVppuZB9oBaDQkpkRzU09uLBeyrcAXVdhUQ71+RuKD6eZ+M7fSURRH LFC600tkHJ3ktMMiclgAswBrzES7iniVsAcBBGAK70vKWtttT0ziedFFgkQ/mGE2 xRDIwWaf33S3uMIdOuVoXfgAZL/UoNOCvqLCugWljc25f0aM2HG57lLnwe1jqZqH g+qH9EgAehaieZN3SfnX2tz1kkPIx+nH3CUVuSHLASfKuZtldsaMBC/YqGaGKLQf eL80V5ZbD9hmoRa2MNWJLlACb8d8TiVRzSctQwqk9mD48jeUYfu/p2gAxTOS0f8O StbieBHKkrsKe7OmmciZ4R4winOg/H831riiufDrw/ARcEeD3X+ZxM5pcJFL8GNl DGizJ6z7z1woIrlhCGVrX8MKuNCqTLiNvp+rGScjj1/d0JrYAb3G9J1dqK9qt0vI PKhbcN9lZ1o4Mn0ngcVVWhK4/JmKVwmVZH68y8xyNCvfp30maKV9sHISo4ZQ+NId O606JumizO/g+EqtUdHPrMIGXuy/R1wg50ZDhnjDYG/DG7iJcnmFsT+3xtteQT70 S7ba5XYR9ySphWxaiqwKjQJOcCYZYe1+R3BDDt9o06+2oqcPnDA= =YwyM -----END PGP SIGNATURE----- --glnNGM8IU/6FdpHW--