Date: Tue, 22 Feb 2022 11:04:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Bruce Momjian <bruce@momjian.us>
Subject: Re: shared_preload_libraries = 'pg_stat_statements' failing with
 installcheck (compute_query_id = auto)
Message-ID: <YhREoCnt2VqKdUGY@paquier.xyz>
References: <YgHlxgc/OimuPYhH@paquier.xyz>
 <20220208034815.m4cwlyimmfjtgvoq@jrouhaud>
 <YgHqCz1tZkZLoyBS@paquier.xyz>
 <Yg9XTF5urx+GzMpL@paquier.xyz>
 <20220218093856.zenl2axicm5mmdc5@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="x6K+qDtD/n5d7y0L"
Content-Disposition: inline
In-Reply-To: <20220218093856.zenl2axicm5mmdc5@jrouhaud>
Archived-At: <https://www.postgresql.org/message-id/YhREoCnt2VqKdUGY%40paquier.xyz>
Precedence: bulk


--x6K+qDtD/n5d7y0L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 18, 2022 at 05:38:56PM +0800, Julien Rouhaud wrote:
> On Fri, Feb 18, 2022 at 05:22:36PM +0900, Michael Paquier wrote:
>> So, I have been looking at this problem, and I don't see a problem in
>> doing something like the attached, where we add a "regress" mode to
>> compute_query_id that is a synonym of "auto". Or, in short, we have
>> the default of letting a module decide if a query ID can be computed
>> or not, at the exception that we hide its result in EXPLAIN outputs.
>>
>> Julien, what do you think?
>=20
> I don't see any problem with that patch.

Okay, thanks.  I have worked on that today and applied the patch down
to 14, but without the change to enforce the parameter in the
databases created by pg_regress.  Perhaps we should do that in the
long-term, but it is also possible to pass down the option to
PGOPTIONS via command line as compute_query_id is a SUSET or just set
it in postgresql.conf, and being able to do so is enough to address
all the cases I have seen and/or could think about.
--
Michael

--x6K+qDtD/n5d7y0L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIURKAACgkQnvQgOdby
QH2c7A/+MUsKr2lRzgeIlZWrctPjaxqTfbIh8gDO6oIq7mcj2x1YBLfpsR0HWWH2
hhD7yboqXmoP7X0Tq7yAyhaYhiY7QqWdqas+2pytPoFZEeZemFpSWDQjyIU4oZ11
Fo6XY3rsq77+RRmMp0sLqYTdCJE107y9WfZUnTputGtQ+fhn7rurpyYQdah+8FqV
Xyvm5cuXNp3WkWkUG60LUspGhrhjdONLAlspy3arlHv5+0HkyrUUaqH/c85x68B0
tr4XzOSqOWVY8Z5fCTJ3RRFeVIv+Bg0u0qNp5zkWIvimeYf9DwVRgMjw7F8lf0kG
rC46pvbaqDT8Tgd57VV0GsnxgGRx809pOTd2mVwcvwljVlYcsSHfu/JsBDtMDXbG
XK9Xm0REOBqrYiiZstlRLnh8HheppWap/Bc44nuFmX6gLPhABvfM+qZzsI/aEGCd
wTGENxudkf5wvZkdfie/Ah3w9xaw2Odoode7o6fRdCLnFVIjWl+uWV+A+LsyPlPq
ZT6uzUuTmBV9UVcOpBHfi40kbYUP/EKou55mz3VS/7qJ87W2u8+H/LoMKIeIylei
3fyfGljHAOQ4C9L/O9pqgQhJruWYAGrpnri+wrVFGFy/Mk8VKxQ8+ElU4dt5v8Tc
L001q13TlGjZhPkq3VQ1oZnrpOiyTVSANo7J6a4IGbfIOQOriDc=
=9XyA
-----END PGP SIGNATURE-----

--x6K+qDtD/n5d7y0L--