Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPZzZ-0000fW-7O for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Mar 2022 01:10:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZzY-0006mw-26 for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Mar 2022 01:10:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPZzW-0006mm-Ix for pgsql-hackers@lists.postgresql.org; Thu, 03 Mar 2022 01:10:51 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPZzT-0005d3-MZ for pgsql-hackers@lists.postgresql.org; Thu, 03 Mar 2022 01:10:49 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 841263201FB9; Wed, 2 Mar 2022 20:10:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 02 Mar 2022 20:10:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=XhBp3aFphMCQTGsPapsXu47RBq2JgO4yrMicmN bsTCs=; b=ik+Syq7uwxEYRm25lEz1K1fQbuf9GuVSsnCc9eRMnynPVDrbly5fvZ 1E6QJUKjkeWRwOj7sPovzToUZ3wH0K17Ce1S/PPdZAAQLjYSWUZlfBrm7YzugG8B sZs8Orcj8u64aNolgdyBhGGuG4A8IKvJiZtLayRTiYBhSUwk5nbDxCLq2fVWHQTW mBRYM+HR8E1jLnmJxProasLIWJ+j7vTXdrq0YrEQZirvDXlDiEc9w3NRuHCub9VZ lGE+TNQQrLJlaWNgENhQbl74x/2Vc94LnI1czxBOIpdnYlKeHMH+keenbEjkyBPn JxVDqQTo9oWYGf1+uOUfzh2B16oesynA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XhBp3aFphMCQTGsPa psXu47RBq2JgO4yrMicmNbsTCs=; b=S5YG+Jfna0Qxa06yYaw2RTzZ4x2jYhjgK bE0EorZaddmIB/TQwcF8DVHsVhdeB37kFk1AZ2TXfvnTl10hOiiTvUGNnk3SVzt2 Fjy9aQxyhi4NDosdQAVzYSrf0JAhYA/4dZRsbobLHQTvqk+Vd+twBc9lvNzSEEaF 69e+74s9RCSsZssR+yttqJ1tBvb7weazoPykzv574+6XGUPz7apLfT7L320aZ+tF otqKv3hzz0fuUgDDXLJao85f6YsNEEHmTHCuujJHkM4Zoky7eFc3CanJCbn8KbtF HDtBvbnk71bD32gqU7LAERq3EkLQfewIw8FdgsCfWPz+t68DXd57A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddthedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Mar 2022 20:10:42 -0500 (EST) Date: Thu, 3 Mar 2022 10:10:36 +0900 From: Michael Paquier To: Julien Rouhaud Cc: Aleksander Alekseev , Tom Lane , Robert Haas , Kyotaro Horiguchi , PostgreSQL Hackers Subject: Re: pg_stop_backup() v2 incorrectly marked as proretset Message-ID: References: <20220302.172235.1181597714315490061.horikyota.ntt@gmail.com> <2976202.1646231744@sss.pgh.pa.us> <20220302163632.6ppfefpw4usen6z5@jrouhaud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r1Z4ffDajn/eNdSF" Content-Disposition: inline In-Reply-To: <20220302163632.6ppfefpw4usen6z5@jrouhaud> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --r1Z4ffDajn/eNdSF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 03, 2022 at 12:36:32AM +0800, Julien Rouhaud wrote: > I don't see strong evidence for that pattern being wildly used with some naive > grepping: Yes, I don't recall either seeing the style with an undef a lot when it came to system functions. I'll move on and apply the fix in a minute using this style. -- Michael --r1Z4ffDajn/eNdSF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIgFYwACgkQnvQgOdby QH2Bfw/+MbQN32LVx7OOWExWov/kNyNnQo/nnB8Q7nontiDwwjlw2wpUNxH0tSuf W9YgdZ4zNPpJrUkSIQDX0Ws6lo0kSmYG2Hdup2L3vwZdwYWdkwePOO83jDbPXqWH c8msvJiW5YKP1KYfclwk3qfSEzKgo7CNdiNeJtcxl4vuxCBhXLt++4HFoc1lApgW RQnm/vXtg2itJ3620p9nlZTSCkTAPa+wa4PFxDIErPEZcbJA7boJe/fhmdjNHacm iLmCqmNa7Co8V4dVN1NAAjxV3LtOmi/OMDoECreqGXMFCpOwNkk+TdlKQ9s9s1GG SEXtlmJwMZvAykNL2OXKkeoo400o7DAvbLDQOmsNJg5x4GQUdmoTdslrYb9Z0WXR 2VAlnM1+I9IJyv+KCfvKuWrfI2fTG5F2riN8qQMCF5ho7HBibS0CDCvDY+Efqggt H/GwKtUAq2d48FKAtzFXtpH1qezqGNVzRWmIbY8HZl9AXXDuMKLYWqt1nYCUIlk+ NpQxsMqIrqK0eQKbyqClLSeKqCGpDU4lFA60F6oxaJUNsTfX/BDpvF+4r2y0Zs5a ywvpYhO22H/oeQ6gO2zQap4WOaJ/pzaOQIeBZ0O4HRLZ5AlWdPDfoFs8fSVyVEw3 oJ0WtIt7HpSofsOf+vLFvAyGufbon9upjERXMYcgoZRrp9aRB10= =1sSc -----END PGP SIGNATURE----- --r1Z4ffDajn/eNdSF--