Date: Thu, 3 Mar 2022 10:27:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bharath.rupireddyforpostgres@gmail.com, nitinjadhavpostgres@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Add CHECKPOINT_REQUESTED flag to the log message in
 LogCheckpointStart()
Message-ID: <YiAZbq1Qz3sxX4No@paquier.xyz>
References: <CAMm1aWZRvUaU0KXbWNtOsNPUp1GJgJ2AL6p33p-_is+Cge_LfA@mail.gmail.com>
 <CALj2ACV+zr=8-HJFBXazFGO+_0VXsTHXzB2EZEEiuDHs-hmDkQ@mail.gmail.com>
 <20220303.093937.2132907787383572158.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="l0qyNhVbSldOsjxz"
Content-Disposition: inline
In-Reply-To: <20220303.093937.2132907787383572158.horikyota.ntt@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/YiAZbq1Qz3sxX4No%40paquier.xyz>
Precedence: bulk


--l0qyNhVbSldOsjxz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 03, 2022 at 09:39:37AM +0900, Kyotaro Horiguchi wrote:
> At Wed, 2 Mar 2022 18:18:10 +0530, Bharath Rupireddy <bharath.rupireddyfo=
rpostgres@gmail.com> wrote in=20
>> I don't think that's useful. Being in LogCheckpointStart
>> (CreateCheckPoint or CreateRestartPoint) itself means that somebody
>> has requested a checkpoint. Having CHECKPOINT_REQUESTED doesn't add
>> any value.
>=20
> Agreed.

Exactly my impression.  This would apply now to the WAL shutdown code
paths, and I'd suspect that the callers of CreateCheckPoint() are not
going to increase soon.  The point is: the logs already provide some
contexts for any of those callers so I see no need for this additional
information.

> Actually no one does but RequestCheckpoint() accepts 0 as flags.
> Checkpointer would be a bit more complex without CHECKPOINT_REQUESTED.
> I don't think it does us any good to get rid of the flag value.

I'd rather keep this code as-is.
--
Michael

--l0qyNhVbSldOsjxz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIgGW4ACgkQnvQgOdby
QH2OVw/9GErwROGBR2YRyGX+MSxJtRYbcl1d+0lmsNRNb0B48bN9CE4/MSQZA84W
w3h0cvva3klyCzZZnCDOl4jowqsH/u9DuqPKLbCjW66FF0couq7QmuRaE5Wai0Kp
R9UPPPQwwparGk5/g3xRHNh3EBpfsGItnRhSTL0FkwaeZMA53Nw7fUUnIHvWvEu8
TFgB3Em3kDzkXMkRWMuEm44Zkxh+NNNknuwFv9Pxl1INnwpRaGz+70nqYjesYb/y
ZtpsIOsuUrxFGBcdjsKBbO+DU0wN7AQn+p2hQW9lfeqytxYkFuCZKmwyPOIgP5kJ
9tL/CpzT+zyqkkpbrBeUZxlgPgE7CXATN+IszoHiJ28S06Ykr29zRCrypdeO3slu
tULHmutPBgf/s84OcRO9zFGstw3/XMphpL67OzyInqwaqbHi28Ef33hOXVgX+ga+
FkB3ualA4nBGX0yBG92UUkRKYe8ZxAy+cCVLEk8F3zx8WYLmKLwNidbuY6v0U/EN
6qKOvdQSsqejYGEg+6qrOWbRwlEijtghu6MIKmZsxLddmXXkLKmEtgU33hgMD2I6
tPN3LcoxmSGECbf9S2XrtmfI5Y0u+ttrSYF5eQUn328bTs/ZDAUxmBVV1nKbxSsl
bshbDRUDA5ghSsWJlvC9d/k8q3BoTpx/aEkDnXR6yyOcPvMUiag=
=6ZG3
-----END PGP SIGNATURE-----

--l0qyNhVbSldOsjxz--