Date: Fri, 11 Mar 2022 12:23:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: wal_compression=zstd
Message-ID: <YirAz/JQ/re059t5@paquier.xyz>
References: <20220222231948.GJ9008@telsasoft.com>
 <YiG9hOS/vivHvJny@paquier.xyz>
 <20220304114405.GK27651@telsasoft.com>
 <20220309131411.GZ27651@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0RCkq0luE5c69fs5"
Content-Disposition: inline
In-Reply-To: <20220309131411.GZ27651@telsasoft.com>
Archived-At: <https://www.postgresql.org/message-id/YirAz/JQ/re059t5%40paquier.xyz>
Precedence: bulk


--0RCkq0luE5c69fs5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 09, 2022 at 07:14:11AM -0600, Justin Pryzby wrote:
> Anyway there's no compelling reason to not use the default.  If we were to use
> a non-default default, we'd have to choose between 1 and 2 (or some negative
> compression level).  My thinking was that zstd-1 would give the lowest-hanging
> fruits for zstd, while minimizing performance tradeoff, since WAL affects
> interactivity.  But choosing between 1 and 2 seems like bikeshedding.

Yeah, I have looked again at the patch today, and I saw no reason to
not apply it to give more options to the user as zstd or lz4 are both
good in their own ways.  So done, with the default level used.
--
Michael

--0RCkq0luE5c69fs5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmIqwM8ACgkQnvQgOdby
QH14HA/9HNpGviSf7/msNh8IxhrA1Yu21i943Ao+r+eqNQo8AhvVRv8ZZJRhTOIO
C4AGH1PnvTlkbo3DQrWb4ilTtS1qFJlAxJW+pkiR220fwln2ObCVVe4yzbWGR6aW
C0WfXSc/NmYNFU8b3rBC61Nn5/5WmXzO6hYWNc1ULzRi0fOgDVj+2DLJnftQOnU1
/HM3IcdALxCpZx5oh8SPmkHJ8nvEJiWA5/Si5tZE6s27fhkMsmeXwJA+4TXa40yY
9JGZHUv5vi0Y17MOa2oQqX1zKFE/csJh78CAygJM3WeBDGMwk32/rGEtE8xSBvZY
9WsJOF2Vtd2j5u/HFJWFrlFIikkJ5zOaxTifYdU1j8xabOTEvgnwCwyTDnGg6Y0f
GhF21mb9STXmmSnIm5pVBhCcRkKsOSyX85l0tC2qMKgSxVW4SMdq0+SfF4DTNfUT
NaO9Rf681A/FNBsXbjQVrHj0AfJf0+wKTZQJWWocHIe6BQEHueu6bB1ec9ytYL6p
ccUsX2fd8cUwhRt0/tNWZHh1xWYFwVaY+oSMP73rKEl99V0qUzPfIar/iJlhpdFS
RBF5IN7oRyFzcquH0iwaqRmascKZzpBIFPKm2jvZOv0pqF5dc9HZaJ7YoZ8y79W4
d6RTJj5hjJiQXHImH+Bm63WRWvT5MGBPv0mNHqAoTpepvLXI58c=
=GhUX
-----END PGP SIGNATURE-----

--0RCkq0luE5c69fs5--