Date: Sat, 26 Mar 2022 14:57:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: Rachel Heaton <rachelmheaton@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>, Greg Stark <stark@mit.edu>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <Yj6rXhLLW3h1vYt0@paquier.xyz>
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220304161039.GL27651@telsasoft.com>
 <CAM-w4HNr=THV3WQoeUPs5jefY8zcXtZJQ5pjWjUAsSpDtEeCaw@mail.gmail.com>
 <20220325132253.GD28503@telsasoft.com>
 <CADJcwiUbfBV0oNNpKvd2H4kP7m2U+7SmL-GAGO8Uv5H3HZUbAw@mail.gmail.com>
 <PSMV5cBDnG2Wd93aYAyTE9RxCPpO0K7ZZQezDkqxwrDTrnp0R8fokD3N8JcmxmuHqAI4cRp_vMmPSUu1igCtaZfk-rLwoSWuBoFiCcRl8WQ=@pm.me>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PjWpHmZAcIKYgvQy"
Content-Disposition: inline
In-Reply-To: 
 <PSMV5cBDnG2Wd93aYAyTE9RxCPpO0K7ZZQezDkqxwrDTrnp0R8fokD3N8JcmxmuHqAI4cRp_vMmPSUu1igCtaZfk-rLwoSWuBoFiCcRl8WQ=@pm.me>
Archived-At: 
 <https://www.postgresql.org/message-id/Yj6rXhLLW3h1vYt0%40paquier.xyz>
Precedence: bulk


--PjWpHmZAcIKYgvQy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 25, 2022 at 11:43:17PM +0000, gkokolatos@pm.me wrote:
> On Saturday, March 26th, 2022 at 12:13 AM, Rachel Heaton <rachelmheaton@g=
mail.com> wrote:
>> Here is an updated patchset from Georgios, with minor assistance from my=
self.
>> The comments above should be addressed, but please let us know if
>=20
> A small amendment to the above statement. This patchset does not include =
the
> refactoring of compress_io suggested by Mr Paquier in the same thread, as=
 it is
> missing documentation. An updated version will be sent to include those c=
hanges
> on the next commitfest.

The refactoring using callbacks would make the code much cleaner IMO
in the long term, with zstd waiting in the queue.  Now, I see some
pieces of the patch set that could be merged now without waiting for
the development cycle of 16 to begin, as of 0001 to add more tests and
0002.

I have a question about 0002, actually.  What has led you to the
conclusion that this code is dead and could be removed?
--
Michael

--PjWpHmZAcIKYgvQy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmI+q14ACgkQnvQgOdby
QH12vg//T1dVbwN8NkojJH9b2SmXjhigvfUVSXGQ9KXAdNwqR2mZcKkfZalxYw49
at2m0JaX61HIiBIWLiyLpjSRLJ0DI1M68PkG/19HigbJY7sx6z56Kz3/mdr0PBCW
ei25euivHp9/JLA2yo1AEiN9XA0w+ALuZloDbJkeSsWd6W2zDcDZ3Z4LfIEtCJQN
RmP+HZgUlFfgv3e89Br7fuEQqFUwaahGUK+EUm6iNfaJKAYtT8eT4mARbGlNz2DP
g4m12VS3yKfmZ/fW5hALG9nOL3HG176dSpK0mI0BZBPFh/pV2duSCNUTrXI0goDI
SdaGyKEb8XdqN0kFiczHM5KfLYCfc2Z8R8cCHXw7Mf2xCWA9tL3Oek7+gu1FaCQm
nwJ7y+BEXajrZyOjYxYsI2j7IJDsVSdWzJvVlF3z0d+auoAK+FtHpIOy4pgfkGcU
gYTbB4Ge0OgF4vmbG3YHvaxBfkA7hyEhiYnOSm/BG9/1NiixVZ2tmc3NYFVxoxRd
HGRRXtVVyk2K8kciMfkkWiSkEsOwSLp+X4BCIONud0pQFwD0I2GfRfBq5CRvaOn+
YxxZqBGohqa3zvkgLrsoYX2JxPKs3w6DN2LfG0R35Ri48PuEFyDi51aMN7CZzr0E
0+09YhQTU/hlbhMPdCg9x8/9dIfufrBHLVTdPvVHiYaHfrpcNwQ=
=3Yav
-----END PGP SIGNATURE-----

--PjWpHmZAcIKYgvQy--