public inbox for [email protected]  

help / color / mirror / Atom feed

From: Julien Rouhaud <[email protected]>
To: Greg Stark <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: Last day of commitfest
Date: Thu, 7 Apr 2022 09:58:52 +0800
Message-ID: <Yk5FXOkVl0BnZYBH@jrouhaud> (raw)
In-Reply-To: <CAM-w4HPEiUMrw29wYbfLZm5sso4K=ZohLOa07g6Owix5N5HcMQ@mail.gmail.com>
References: <CAM-w4HPjyR9oHm7YdWzQ4MmhNyCA24uA7quunfHNBeYq1swr5w@mail.gmail.com>
	<[email protected]>
	<CAM-w4HPEiUMrw29wYbfLZm5sso4K=ZohLOa07g6Owix5N5HcMQ@mail.gmail.com>

Hi,

On Wed, Apr 06, 2022 at 09:32:31PM -0400, Greg Stark wrote:
> I won't touch the Ready for Committer stuff until after the end of the
> commitfest anyways. I did put those two in that state already.
>
> Right now I'm trying to get a bit ahead of the game by going through
> the "Waiting on Author" patches. The documented process[*] is that
> they get Returned with Feedback if they received at least one review
> and haven't had any discussion from the author in 5 days. I haven't
> been doing that but I'm saying I'm going to today.

FWIW I think that this 5 days threshold before closing a patch with RwF is way
too short.  As far as I know we usually use something like 2/3 weeks.

> However I didn't get through the list today. I'll do it tomorrow.
> 
> The first batch of patches that will be Returned with Feedback are
> listed below. If you're an author of these and you're still looking
> for feedback then I would suggest sending an email describing the
> feedback you're looking for and moving it forward to the next CF
> yourself before I mark them Returned with Feedback tomorrow.
> 
> * Single item cache for Subtrans SLRU (Simon Riggs)
>  Received feedback from Julien Rouhaud and Andrey Borodin

I think that this patch is actually Ready For Committer given Andrey's review
and Simon's answer, I only realize now that neither Andrey or Simon changed the
status.  The only remaining nitpicking thing is the variable cache name and
over 80 chars comment, which is the kind of thing that a committer can tweak at
commit time anyway I think.  I'm not sure if anyone is going to pick it up now
but it seems uncontroversial and useful enough to be moved to the next
commitfest.

> * JIT counters in pg_stat_statements (Magnus Hagander)
>  Feedback from Dmitry Dolgov and Julien Rouhaud

Note that the code looks good and no one disagreed with the proposed fields.

The only remaining problem is a copy/pasto in the docs so nothing critical.  I
personally think that it would be very good to have so maybe Magnus will push
it today (which would probably instantly break the other pg_stat_statements
patches that are now Ready for Committer), and if not I think it should go to
the next commitfest instead.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Last day of commitfest
  In-Reply-To: <Yk5FXOkVl0BnZYBH@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox