Date: Tue, 29 Mar 2022 14:03:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Georgios <gkokolatos@protonmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <YkKTEOlCrk44vAEJ@paquier.xyz>
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220326162156.GI28503@telsasoft.com>
 <CA+TgmoZJyx7anpGsZbOgpcP6RmyJ1-kWoKuuCYJsNohRVbOmGQ@mail.gmail.com>
 <20220327160635.GL28503@telsasoft.com>
 <CA+Tgmob5COx7=e69vXk3OajAg_SwpAf8KKdGABToP9ms+UXErw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gHem/OcEyhfWALpd"
Content-Disposition: inline
In-Reply-To: 
 <CA+Tgmob5COx7=e69vXk3OajAg_SwpAf8KKdGABToP9ms+UXErw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YkKTEOlCrk44vAEJ%40paquier.xyz>
Precedence: bulk


--gHem/OcEyhfWALpd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 28, 2022 at 08:36:15AM -0400, Robert Haas wrote:
> Well, I think the first thing we should do is get rid of enum
> WalCompressionMethod and use enum WalCompression instead. They've got
> the same elements and very similar names, but the WalCompressionMethod
> ones just have names like COMPRESSION_NONE, which is too generic,
> whereas WalCompressionMethod uses WAL_COMPRESSION_NONE, which is
> better. Then I think we should also rename the COMPR_ALG_* constants
> in pg_dump.h to names like DUMP_COMPRESSION_*. Once we do that we've
> got rid of all the unprefixed things that purport to be a list of
> compression algorithms.

Yes, having a centralized enum for the compression method would make
sense, along with the routines to parse and get the compression method
names.  At least that would be one step towards more unity in
src/common/.

> Then, if people are willing to adopt the syntax that the
> backup_compression.c/h stuff supports as a project standard (+1 from
> me) we can go the other way and rename that stuff to be more generic,
> taking backup out of the name.

I am not sure about the specification part which is only used by base
backups that has no client-server requirements, so option values would
still require their own grammar.
--
Michael

--gHem/OcEyhfWALpd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJCkxAACgkQnvQgOdby
QH07Vw//XjwO+GOgQZn5H5tUtMgbIb3t7ubVia+dSg77Filbon5RTkQbOv5eVznN
ECyVzCqyZGh28qrPlZEQDj9qUQ+94HGWpYsBZNsyV3o3V8ryNK/NrXZIw/BC4ZsD
wctUJA3dMi6y5vMi8K0yJrD6yQLV7v7zCCm2xYCvTasY0HddiXelD9+KGbEvohQK
SLHPbhrmwGE3U7CTOmULregCZ3jnyYcDWADA59e0ff9jTANZk2K0UcLYZqhhBJXc
GNorqL4Jml6ZdqRJIGxQ/H0B5SWbZ7y2efRDkQbTa2Dm+3mIEiuoHCC3fHx498tt
+x7D+OtGQGB8zAMimEpWBkIQCfwAP/kvxZchXAgeMG0j59i6LSs3lLVIO5MKM7ME
OmVmK/sdIyT4+F11wYUfDzxzK9TAu0JJTxO/6NGIljk3UOa4Z3WcDRFv4rg1yBbk
HB5QIwKnNXfpChreU7FxurGCNi/U75rKKhjzqo12yT/uSCv7pyxf7RCDlw8GHcoP
zrgqQAXK1uMG/7NjSLkobKJcb+goLVyB8XAWNPJyUlQhCaBNMkF7v+jmIevMqn5z
RAVT4ZX3/F26olaZmiEJre47P3DmXLkSPUVeSRvj2jInCYZQs2qeP9wHStsYXitj
gbM6Ob4N1NraXa/ran17isgLtLIVeg3Bcy/wpp2WZ2kx34XBt5s=
=1OJh
-----END PGP SIGNATURE-----

--gHem/OcEyhfWALpd--