Date: Wed, 30 Mar 2022 15:36:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Georgios <gkokolatos@protonmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <YkP6UvILdAHaq8JS@paquier.xyz>
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220326162156.GI28503@telsasoft.com>
 <CA+TgmoZJyx7anpGsZbOgpcP6RmyJ1-kWoKuuCYJsNohRVbOmGQ@mail.gmail.com>
 <20220327160635.GL28503@telsasoft.com>
 <CA+Tgmob5COx7=e69vXk3OajAg_SwpAf8KKdGABToP9ms+UXErw@mail.gmail.com>
 <YkKTEOlCrk44vAEJ@paquier.xyz>
 <CA+TgmoYd2XBJ_vzHUKwR6u+usmNNQvz+2J+ZDWhrMYXCGGP2Fw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Lzbw62XeOmkciagV"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoYd2XBJ_vzHUKwR6u+usmNNQvz+2J+ZDWhrMYXCGGP2Fw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YkP6UvILdAHaq8JS%40paquier.xyz>
Precedence: bulk


--Lzbw62XeOmkciagV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 29, 2022 at 09:14:03AM -0400, Robert Haas wrote:
> I don't know what you mean by this. I think the specification stuff
> could be reused in a lot of places. If you can ask for a base backup
> with zstd:level=3,long=1,fancystuff=yes or whatever we end up with,
> why not enable exactly the same for every other place that uses
> compression? I don't know what "client-server requirements" is or what
> that has to do with this.

Oh. I think that I got confused here.  I saw the backup component in
the file name and this has been associated with the client/server
choice that can be done in the options of pg_basebackup.  But
parse_bc_specification() does not include any knowledge about that:
pg_basebackup does this job in parse_compress_options().  I agree that
it looks possible to reuse that stuff in more places than just base
backups.
--
Michael

--Lzbw62XeOmkciagV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJD+lIACgkQnvQgOdby
QH26ghAAmBjQriX7dSpLGv9lZHAo/taIe75O1qcCILSyrGEx7ScMtdHZMzdmALcT
r1LF+e/wYPf9S5OLnL83vP3rz43KKdiQHiJLQwXH2T+Rf3oxqTVVz3NBGbRh9eRO
fyPZExOteva88nN8l4q9OeSLUX35ij0ftkQylwBiPyxzCGNcLfzXz+Qwq4CGylaa
HFNnjWEP4b8cwU8PSdfq6TSBdUamf5wZa9KnAiYq6ub4C5AYRUa6UJBQusckP6h1
qRgdk9ygfYsohL/SZpss/bgPbZ4lRJNPgYNajgWZobnqzQHqiSCBo9udoPRZjutu
DuGGYOM/GDCN6AOoGZ983YF27R/WBvXFmkKbthoLCtN4MrF0fEQqvh4MLALYLCF+
/d5Lxt/gcXqEFujURjBYJwOmwFn+zCZchzXJz/QInyBNRtDU7BDxNBqishaAqVM6
Hkktchk4Aviu3l0NrCpjfcU7IF2YJUISNqdy419HoXjsgInmhGTlL8jGoFubhetZ
mD/F+BlFCyCLTdGXeqJda/wqUrJj8xwaopq3Y+CGHdlYZO+X8CxPuirB9aQs0p43
uozCaiVaotd0FCh/d2gKsENnPqtzuax7VyrFPJBQuZiIDXvsyjgJ0ea3/oDhCpR5
Z46FwUEW20X4WPWb8zLeN0oy4MQPyGISmPqSN2baRnsbLgQLRyQ=
=rxil
-----END PGP SIGNATURE-----

--Lzbw62XeOmkciagV--