Date: Thu, 31 Mar 2022 16:42:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, okano.naoki@jp.fujitsu.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages
 doesn't work.
Message-ID: <YkVbbZBiC4yxXPuc@paquier.xyz>
References: <17448-0a96583a67edb1f7@postgresql.org>
 <Yj6oxYsBE5LXA8ZP@paquier.xyz>
 <20220326082408.moh55zuecxjmewnm@jrouhaud>
 <CA+hUKGLwOSf-QwVtCcKx9xvugN2BSzEBBeD5DNyTXgcSRp5sTw@mail.gmail.com>
 <YkQMyhsP7xgLDDT/@paquier.xyz>
 <20220331045908.bm5edcacvymgwwv2@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kWVB6L8w3Lfg8q2K"
Content-Disposition: inline
In-Reply-To: <20220331045908.bm5edcacvymgwwv2@jrouhaud>
Archived-At: 
 <https://www.postgresql.org/message-id/YkVbbZBiC4yxXPuc%40paquier.xyz>
Precedence: bulk


--kWVB6L8w3Lfg8q2K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 31, 2022 at 12:59:08PM +0800, Julien Rouhaud wrote:
> That approach seems sensible.  For reference the versionhelpers.h seems to be
> available starting with VS 2013 / v120, which is ok since that the oldest
> version we support AFAICS.

Hmm.  This points out to a different problem.  The oldest version of
MSVC supported on v10 and v11 is VS2005, so a backpatch means that
those checks would need to be tweaked if we'd want to be perfectly
compatible.  But I'd rather not enter in this game category, limiting
this patch to v12~ :)

> Now, I also have the exact same result without the patch applied so it's hard
> to know whether it had any impact at all.  Unfortunately, I didn't find any
> information on how to check if "large pages" are used and/or by which program.

Okano-san has mentioned VMMap upthread:
https://docs.microsoft.com/en-us/sysinternals/downloads/vmmap
--
Michael

--kWVB6L8w3Lfg8q2K
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJFW20ACgkQnvQgOdby
QH0NqBAAmysFQBzrmU7T70D8GTsTJ8hNhy8tD0z9rphCdFfumZlViFPBhJTewuvY
U5/qSTLscT1uPnfUfZx+tlUIGM5ymiBfbOEAhvBlccn0ZTlNSWIgk6aFmPSvbjP3
uFuRDWAM1IRXC4bHWV+ngZ6pEzRIPYZ5fNmos8dJFZhBRz3MC/R82Ll4SHogwGHu
261DPrlbATeGf1az3jzOe0u1IoJQ05KkmKaKSOruRAeJ8i+VeU26LBBI0Ek+66I7
Nso2Uzg97s4sU9Q3hwwMsN3KugA0+Uq8nW3ndreMwbOFjuG2GR6I2GdY3dzqyuzG
OuVRKhEYfapOMIqywU3O/fYpqUijBbaaMq+UqcbdLk0AOju7WcV8lCO21XguzxoD
ZEznNoHiSqyqGiExfEG1JsBb6aYPUHg7xpkbumaeZC+PWmK3sC/rYtWxb4JSkL4D
X1Jv533qHXbT6XG5FZFUgiOl3jIluZoaI4ljmqvmSKHoSLV5ijSwWR+0qyGcOzQ6
2yCbL1QrlmqD5mveW4HiIz8pDLuaW7BU0BqcvF7RxqLwBSYNyQuPApHBpM0Svd4w
+q1GjSsgJXcKMq03+m0tD+Hez2Bm0We/UOy0YzlkrHX9QkFEOxdF7E4/lUTfqjwy
FALHwjYW69PRqzqchg/yiWvks7B7sNveY6I6m7sS7YeCTwdnEtg=
=OLtw
-----END PGP SIGNATURE-----

--kWVB6L8w3Lfg8q2K--