Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na5uP-00025Y-TE for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Apr 2022 01:17:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1na5uO-0000v2-RU for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Apr 2022 01:17:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na5uN-0000uo-7z for pgsql-hackers@lists.postgresql.org; Fri, 01 Apr 2022 01:17:00 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na5uK-00036n-N7 for pgsql-hackers@lists.postgresql.org; Fri, 01 Apr 2022 01:16:58 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E57C05C013B; Thu, 31 Mar 2022 21:16:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 31 Mar 2022 21:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=iTCiEVw2vGV4wJrXZO18VSjXjThtmF1molmEP8 9Btts=; b=fw0/J1zBut/KVbRCi8jB/6dtSzadFOZ3S9osSya/GrjD0ivl0EBjRD ZyFX2rGzEyov+ciEwAgNdYxE5iEBzVv8j5Mw/XmeIjdkBCdVRwtceXJqiirY3oZC hgiCoEZ2Zk2+WU0FGdA44IfQv7zEahMyWIY3cXpCTPts9VaN7qnTx0D86Zc7uhdC 8o7dJbSlwGGdQc2reGeq/ZSGQEgQYFCkC6bxj2BT9HRCqIsKAX3Wvklqsfkh81FA 6pua7DwB1pIpkAdL74h061WhFyYeLBy0gubXtR4HZcU7hRQkbcoS3zYWqmRyUrOS MbNlqiAqsoqSkitudo9YA+TkwRpF36VQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iTCiEVw2vGV4wJrXZ O18VSjXjThtmF1molmEP89Btts=; b=fuS/Ca3M6UDiNlcBTFWCUyD9juQzi4MgN +jlYo2dDvz7LeVrermidhuWqWVuIy93KVn2Rf9EbdYGQsypR/zBkIfEMhLgzQALd /SujSZpekjRwD0DBKngOaUd+i/oSCPgpv/ZKdYpLHHuz7BE823FfDyUej9zJSooZ QPZHAxCog4q7KMWZVidcCJ/Hjx1hwV7bYLVgr7FiUXtEOK78iWxv2D4P/h6HwUVI Rjtv3sZHEBig77iMJbTmoeMBaBxxHhp66CR36ZUoHc13XpxNuQtTh2ZrNa2RxTo3 EiwePAH1iDS9VnBj0d5exYNsyCCoCZFcsabUD/edWTahW6onfqykQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeihedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 21:16:52 -0400 (EDT) Date: Fri, 1 Apr 2022 10:16:48 +0900 From: Michael Paquier To: Tom Lane Cc: Andres Freund , Thomas Munro , Noah Misch , Julien Rouhaud , Andrew Dunstan , Postgres hackers Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set Message-ID: References: <20220302080729.q6wej3zlyaorjhri@alap3.anarazel.de> <502623.1648702814@sss.pgh.pa.us> <20220331053616.u446wsr732quuzer@alap3.anarazel.de> <547429.1648734590@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EIVehzJPeyccW6f6" Content-Disposition: inline In-Reply-To: <547429.1648734590@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --EIVehzJPeyccW6f6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 31, 2022 at 09:49:50AM -0400, Tom Lane wrote: > Well, let's go ahead with it and see what happens. If it's too > much of a mess we can always revert. Okay, done after an extra round of self-review. I have finished by tweaking a couple of comments, and adjusted further TESTING to explain what needs to be done to have a dump compatible with the test. Let's now see what goes wrong. -- Michael --EIVehzJPeyccW6f6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJGUoAACgkQnvQgOdby QH0KuQ//VjrLMEg7PCB5kb0+Ieu85/i/JhRTzuniBXie6OpjYxEqaXZGAcAU1b6x Cmbm2Yfuu/9FF9tUVi+2ZrZQ9yILdj8xQrsaOwx+iF2P+Cs1ettfu6gV95BAbmJl r/H7b5xg50tsWiOnChQ+xXaOh2G960q5GvN42S4Ar0RiI4dBlfP37JftlAMOaedq iT98escOnw/PxkYjAid55zSlmo/7/Hq/zyv3Yi30VHTNgFdeWGeo5yDh8hZgrPF1 Yx00oMEimDDqUQKIzwfn27o1gQs3jZKtaIhBOBDDErv0T2KdTLt4EFPkHj6Ae78N kEixCv9hlLVLlKHmBUPsRDFRjBx2fZPUK2Cp65SDsoUGAoS1nAFyRzg2yV+NxM7T CR1pKRPyeVNQq96CKyzU3ndc3qTyIwnNKxeGy9vh2pfdlHhBgmpqTCr1R5DVcLi/ xHQTGFdFOgSwLPCa8c6t/a19wsCDzYU1/50NuXzN86xs0qH0P/0Ll3XZl8R0hEtE 3VZbYHxNMR64qAlpTEIQ0kscvYZQwXwdxusaLP80MIfYPos72CajI1l4Qcqz9Ptn 0JdndNGfSWnHIvlYiUO7DaZOyunb5oZrxgjBt+e2eOJ13db9Eh5YR9kQPW/H1L/L bvNw9gpQUJo6wU+GeQauJgCQl4NMMntu6undiGbLki1nLEUDLcA= =sB15 -----END PGP SIGNATURE----- --EIVehzJPeyccW6f6--