Date: Tue, 5 Apr 2022 08:46:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Run pg_amcheck in 002_pg_upgrade.pl and 027_stream_regress.pl?
Message-ID: <YkuDPrFHGHcq153O@paquier.xyz>
References: <20220403185303.futnxfj64llw4uny@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7BCH0Hpfz3gEVc4G"
Content-Disposition: inline
In-Reply-To: <20220403185303.futnxfj64llw4uny@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YkuDPrFHGHcq153O%40paquier.xyz>
Precedence: bulk


--7BCH0Hpfz3gEVc4G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Apr 03, 2022 at 11:53:03AM -0700, Andres Freund wrote:
> It seems $subject would have a chance of catching some of these bugs, as well
> as exposing amcheck to a database with a bit more varied content?

Makes sense to me to extend that.

> Depending on the cost it might make sense to do this optionally, via
> PG_TEST_EXTRA?

Yes, it would be good to check the difference in run-time before
introducing more.  A logical dump of the regression database is no
more than 15MB if I recall correctly, so my guess is that most of the
runtime is still going to be eaten by the run of pg_regress.
--
Michael

--7BCH0Hpfz3gEVc4G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJLgz4ACgkQnvQgOdby
QH3Rkg//aJ51hA4+bwGS722yrdrxEhfHFkh4saM/Xb/S/tcFZqpDrZqx68s00GLb
y6v7g9Nx7W6FZslDC+RUqVKaiRs60azRsZwjA7aomKS6j21VvIWb6l6vYEW9Dn92
sylb3odLesxzzyLIGogHSHURb+C4xIv7x0s5PxUi44H4Z9xYge2IJFuMzOyIjL3G
I0kZisuZ/Jwtatk4Sn/bkD5a4hnDCnXadZ0uSbabTBnFpBgK4bjqgafOZMgW5h61
Nlb5q2QudwxbWL6B7PExigTi0MH8qM4hWz1fzvPHfIMGX6wRhKneXyzoSQBNFh2V
5j3GCXVbqGYkNkX4VyMeBeANyLh4Ue9EhD+xrSivypBj/fStiUIn7ez4Yh0Y+vTf
PYVbO7G1j6EIamX8iWEzdbnduqt3nlhXW96XCWBBvDsOK8cnFK2u//tSvCcRxVGn
5y6hrEAF1Vk8urQ7tNj17d13KqvCQ/W3DQAVfhDH8EaAxOrqJO8t2kRENoOj1N+U
CAAsHOtBlbyk18+3O1f1xmXgsbTUnoP1LxyWOvoDgmn6VGKYFSI/bqWujh+d58FO
AQxkJE2pMJjuNP206tOp0PAzcN00Npkcx5ymbycQamWeeNz6XMqu+p1DIH/7g9RG
m3Xfv5WYugTK8pJFdoxTkYfNUkMRWqv5H0OeOwm9XUBFqZqkWpI=
=irhg
-----END PGP SIGNATURE-----

--7BCH0Hpfz3gEVc4G--