Date: Tue, 19 Apr 2022 11:33:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and
 recovery_end_comman
Message-ID: <Yl4fdcOqQhAgB5Sa@paquier.xyz>
References: <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
 <4015413.1649454951@sss.pgh.pa.us>
 <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
 <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
 <YlT23IvsXkGuLzFi@paquier.xyz>
 <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
 <YluU3C4i8sHoVeOQ@paquier.xyz>
 <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
 <YlynfULh/svXYbfT@paquier.xyz>
 <CA+hUKGJYk56m7sycB4KhrEaYRnTYN-P3jYaXNbMGjsTicEHn6A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="up2Pm+NKWcKw6r17"
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGJYk56m7sycB4KhrEaYRnTYN-P3jYaXNbMGjsTicEHn6A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yl4fdcOqQhAgB5Sa%40paquier.xyz>
Precedence: bulk


--up2Pm+NKWcKw6r17
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 19, 2022 at 09:45:11AM +1200, Thomas Munro wrote:
> Delayed response to the question on how I did that, because it was a 4
> day weekend down here and I got distracted by sunshine...

Happy Easter.

> I think that sort of thing actually worked when I tried it on a
> beefier workstation, but it sent my Thinkpad that "only" has a 16GB of
> RAM into some kind of death spiral.  The way I succeeded was indeed
> using a wrapper script, based on a suggestion from Andres, my
> kludgy-hardcoded-path-assuming implementation of which looked like:
>=20
> Yeah, it might be quite neat to find a tool-supported way to do that.

Thanks for the details.  I feared that it was something like that for
the backend.  At least that's better than having valgrind spawn all
the processes kicked by the make command.  :/

> Tangentially, I'd also like to look into making
> PostgreSQL-under-Valgrind work on FreeBSD and macOS, which didn't work
> last time I tried it for reasons that might, I hope, have been fixed
> on the Valgrind side by now.

Okay.

As a side note, skink has cooled down since acf1dd4, and did not
complain either after the additions of e61efaf and 1a8b110.
--
Michael

--up2Pm+NKWcKw6r17
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJeH3UACgkQnvQgOdby
QH19LhAAjtHTAYMfeyzW67o487VcKUJA0KYNipqu8umRNSRrDisGOp8zITN/pPNy
u4I/JLCZUF4VWoPy8zgsn5uBkbCYnikqNZGLj5wLQkzWX/cSspgFWNcgqFB50mWo
rV0BIcz5UjE4uE9Qb5QIToMCbbDfk2GVrk+FkHnH+eKSfoHlhsuHBztTuBHCK+pp
Tu6cddgnKTULhG4oNAHEveSMCYsO9zkfQkChgG1zaXlQ8mvvRsthZK5sV0m7YW4d
E6wEgiO06cL0Kg0LkFYS0Xficb9X/FwhgRU+s+GR8OxWKfW4GDW49UN1DTwKnVTI
AnPoMZw80zpXmxFHi4EHpJ+BvuZILd7bjv13sMBCvslb0ev9b049ugNqBGTrl/gN
Xf5hq0IDvZEpz0heQU3LnHVPcaWrEamxc72fYe5pD0Z1E8ZLVw/cbBC7qLu8fNf5
aU1MdIbSYqqtEDShzAWZ0fNplVFeNCSAFtmTiZfVDGmwm2geyydzqgtuNbMh/LRc
ouYb+0QXmf46HugUfEiMH/Hgm6ZklU6FTPsqOTFOfOCPO13E6wZlFZ3xKu5JtmnE
uyThatn31VpsnNZulTF0AeBFlBdXaxdzxejYSLTgwImV81wO/ObeBnJuLF3abzG0
fk6Ikt7AmhsmUl/LAj4cBFp/rd4VEJRdrV6N2XYBxfDTvuhD6vY=
=jF+K
-----END PGP SIGNATURE-----

--up2Pm+NKWcKw6r17--