Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncsUu-0008IJ-8p for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Apr 2022 17:34:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncsUs-0005nt-1B for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Apr 2022 17:34:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncsUr-0005nk-MS for pgsql-hackers@lists.postgresql.org; Fri, 08 Apr 2022 17:34:09 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ncsUp-0000xD-18 for pgsql-hackers@lists.postgresql.org; Fri, 08 Apr 2022 17:34:09 +0000 Received: by mail-oi1-x22e.google.com with SMTP id v75so9551625oie.1 for ; Fri, 08 Apr 2022 10:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z6Xa2HsCZm7uTt3D+mdtUHqCW26YAk4KXV2QlaYlrPI=; b=XLn98fpqmKTDFBS/UkmPKyynvWwmoIwiZvDK4p4AHR7EI+Bbc7WXjp59Sw3ve7cREt hYhQZgONdv7Su+nzYU6cOjtZsAOmWPJd4BkdX9SCwGEpFAoqOfXj0cbjSDWMvFjd2Fme ixPLILJxDJcmSlFVZ/b5FCWctXxnHnkQMzZWEU7CreYpdg/5+gEwZmNRjBLSZBJTWnqc l/PinZ6EDFRzrOc9lj9nBIcNVmJcq0A4YeDk51iuH7Q6ilCZ2VWGzqHdtrHKlnanWVLp iR0iXuE607NugKH+bELAvmfiMBE/u4b1G9tXj8z4kGQQlNqC9zEdo7HyO4UA6IUAbcv/ SfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z6Xa2HsCZm7uTt3D+mdtUHqCW26YAk4KXV2QlaYlrPI=; b=cVxujf9JLfGploRuzMjJ6lm8n4NnBsIdeKshDyZPqv/PZGp7sZuD20ZTg+ShZTQwow T2qkKpTSMDtODuqqX4ffz2afHce5zCUS2l1MnPC2WlPA0HAswUVuo+1B1dysxS7xTq0V oyzgJRQTCn/ZXf/OyPngEiaComnVGvk1VyzmEO9bd8I0eYfRwmUHKovq2dKLfHnNXCb9 rnpUadfCbhVtq/FIITwjWsfyOIFewtmFYlNfnC1oSVvPosXDDmCbs2bFqNmpzeJjoonw BdQBbS4gQrX0FV9s3seNnFxp/AkSMLIYshvYKWMCPCMQlqyZ6575pnR6M1OxPcYnxTZl 7Bow== X-Gm-Message-State: AOAM533zYDCkMsdF9yRt0YoBLH/zcFshlmU/IHiDAb0W61fvW6FjhjnJ hhidlFVXYnFPi++Pxp5z4e8= X-Google-Smtp-Source: ABdhPJxGzz098HHgVS2K0vJwbiebp/4L/IU9BBn+p/AYbdn3QHDCNYlISigbPRE1tFaiEmD2/5uwEA== X-Received: by 2002:a05:6808:1485:b0:2dc:7839:fc35 with SMTP id e5-20020a056808148500b002dc7839fc35mr414008oiw.63.1649439245014; Fri, 08 Apr 2022 10:34:05 -0700 (PDT) Received: from g (75-164-130-196.ptld.qwest.net. [75.164.130.196]) by smtp.gmail.com with ESMTPSA id bp21-20020a056820199500b003298e6877c7sm2770954oob.29.2022.04.08.10.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 10:34:03 -0700 (PDT) Date: Fri, 8 Apr 2022 17:34:00 +0000 From: Mark Wong To: Tom Lane Cc: Chapman Flack , pgsql-hackers@lists.postgresql.org, Konstantina Skovola Subject: Re: trigger example for plsample Message-ID: References: <164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org> <3528727.1649370593@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3528727.1649370593@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Apr 07, 2022 at 06:29:53PM -0400, Tom Lane wrote: > Chapman Flack writes: > > v4 looks good to me. > > Pushed with very minor editorialization. Mainly, I undid the > decision to stop printing the function source text, on the > grounds that (1) it falsified the comment immediately above, > and (2) if you have to print it anyway to avoid compiler warnings, > you're just creating confusing inconsistency between the two > handler functions. Sounds good to me, thanks! Regards, Mark