Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndohz-0007Ed-2L for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Apr 2022 07:43:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ndohx-0005m3-Rn for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Apr 2022 07:43:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndohx-0005lu-Ie for pgsql-hackers@lists.postgresql.org; Mon, 11 Apr 2022 07:43:33 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndohv-0006pm-RW for pgsql-hackers@lists.postgresql.org; Mon, 11 Apr 2022 07:43:33 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7CA0F5C01F7; Mon, 11 Apr 2022 03:43:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 11 Apr 2022 03:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1649663010; x=1649749410; bh=V4dTAVNDhz fXERqnWi7127htX0AmUdYL4flgjJWQJyw=; b=d+6ToPz6Iuf2lBPzcwJfjCYJ6f hv2nfm3gmNsoVZbrAYKm6pSUS8GIY9tIunXphjbPLvLQbtbGbmbQYfIl8St8ENWe sEgoUwrSjffZnfcpqdFREflguwWQwDRwLZgCIzSKJ0A83Gjzpxc2m1/XqHEChC02 OIBDwMwb2VybTgUMYIazbs9aqfevIKoJq1TCn4P0HoLN3ziu+aUetAB7waY7uhfO iJIATGcEAEvyOh8VO+IaFbeNavszH+Yt7M6DzNy9qyFkyYC/7d4sX+HFfpIMCDr6 Y0UrzY86rcYB75xhDHherzHxJmv7Dla+m88+BHDmlEEbam1vk4DJjWA2sD4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1649663010; x= 1649749410; bh=V4dTAVNDhzfXERqnWi7127htX0AmUdYL4flgjJWQJyw=; b=I 9heWVRg4oINa2v8rVkwOnNIIMS5xuVIKqFRm8RF7hzfilGvwiLAsXgTj+JOcUlLn bjVyFwlarvrD0vM943gaS/g2kZnfS6t3wt7xlrOMWV1S0meOgXO25Mns6pt2xdq/ 9brIaZtmnsXVLdkqtPgHJH+rl1iRFDlzeH+Ao8o6Zts/Mdh/1gGCJ6/bRWOdpbsl Ncq0HJPAC4wxW0gx6uVtDzIs24HnOv6aWagpqtcsCU/imb2Zwzf1m/eYPoZ1nvfN 0Kx5icZGqjomMjx4JFKFPNYPQOmNxqO66mOGsrdmGa1bygxVlLTJnwZ88HVFv4s4 lDI+yFeoR+UX5REbLTHBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekhedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtdorredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepheegtdeuheekteegueevtdel leekgeegfeetfeejjefgkeehieekveejhedujeehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Apr 2022 03:43:28 -0400 (EDT) Date: Mon, 11 Apr 2022 16:43:26 +0900 From: Michael Paquier To: Thomas Munro Cc: Andres Freund , Tom Lane , PostgreSQL Hackers Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman Message-ID: References: <3385143.1649353230@sss.pgh.pa.us> <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> <3386734.1649354265@sss.pgh.pa.us> <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de> <4015413.1649454951@sss.pgh.pa.us> <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qFdr8TqTlHwZLPaa" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --qFdr8TqTlHwZLPaa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2022 at 06:48:58PM +1200, Thomas Munro wrote: > Sorry for the delay... I got a bit confused about the different things > going on in this thread but I hope I've got it now: >=20 > 1. This test had some pre-existing bugs/races, which hadn't failed > before due to scheduling, even under Valgrind. The above changes > appear to fix those problems. To Michael for comment. I have seen the thread, and there is a lot in it. I will try to look tomorrow at the parts I got involved in. -- Michael --qFdr8TqTlHwZLPaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJT3B4ACgkQnvQgOdby QH2M+Q/9EkvR2pOI2wZ4ytSaTE7vhSr8vz9Iqk/H4sEFb/pgPuDxS5AmNksdvKoY rKSsBHZGZt4T9BpevMpFF1QwEIBV5eO+TJ2sSh6ar0IvqEU/5vJMpVT4vNYGiRCO kbMbfT1iNysjuEzpULncpSaThUMwSL/RNv/94ZpXN6qOwNq3Gfx9XQB1sCV1OonC p8ar/NadEmsIbdDzyrwup9NEPreYEPPDx8dIV73oEl0I5uFvwLOmdkftYratopTY Rd71Fq9AkxKkDpb+2cSVhbP1w1kqK/ZocLKV8OR3omOZWJHxMJPm4YuKWpwZYC/T QAe2oSnhJaijYRqDlgK2RaXmBR47Mqty2HPFLQh0yPLPcL3cvL3xS/ceD/S1+NkA zjV6/pX9RHk1RlyB15CwWnDJZkN0dPvuyf625ENhEaoT5G18VfI9jM0PpWnh3MDj qnPfh/Vi0zLqUVanFlycLY8o8bYHgmos7olH9ONayYAnV18Cx+BWQQnzi4zv3/1q UPIvWkXAkmfAx3xC0ORMYlKlnrqPrIijiNkr3xqGLfY+d/2pl8RDDgh1p6ZpE/nP 4iQhfquI6GJ0x+oQYdFF5L/j426RX9svMosWqV6PNlR/MnpSu1QVBfbB0Pufp1+Y BBWDQf9ZtPWDcEcFXRxEy1WXSb4/JlG6TKQP2QQou2jkEJyDOGQ= =WSbS -----END PGP SIGNATURE----- --qFdr8TqTlHwZLPaa--