Date: Mon, 11 Apr 2022 23:34:32 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
	Dean Rasheed <dean.a.rasheed@gmail.com>,
	Joel Jacobson <joel@compiler.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Schema variables - new implementation for Postgres 15+1
Message-ID: <YlRKiFZNKhWSNH4T@jrouhaud>
References: <20220129051946.outrihp7phagjeey@jrouhaud>
 <CAFj8pRDbH4vpP5BTieD4Mw5OtdoLBb0ucqZhYB5c1SFPcqVoxg@mail.gmail.com>
 <CAFj8pRCzVU8DHZmRChJot5OJfkMMg_8PWXz5k5u+YT=BkfCVrA@mail.gmail.com>
 <20220202140852.7wivednqmjp7nibf@jrouhaud>
 <CAFj8pRC6Lqn+jXManUO3+qsgjvevQiABhsM1CUTo+z+C_BoLYA@mail.gmail.com>
 <CAFj8pRAoDDDCt1W6jJOGjnfjSYzs_Ei9dN4=RDE+mcVq9hJOhw@mail.gmail.com>
 <20220303070652.xjmyd6xkeqfazvjh@jrouhaud>
 <20220303071626.c3ok2qz7s2rya25l@jrouhaud>
 <CAFj8pRCeu_Aku3mHqS6vDL1p02u1Ed5QiOGL3e4CPKyvkW6s3Q@mail.gmail.com>
 <20220410204333.GA26620@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220410204333.GA26620@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YlRKiFZNKhWSNH4T%40jrouhaud>
Precedence: bulk

Hi,

On Sun, Apr 10, 2022 at 03:43:33PM -0500, Justin Pryzby wrote:
> On Sun, Apr 10, 2022 at 08:30:39PM +0200, Pavel Stehule wrote:
> > I am sending fresh rebased patch + separation to more patches. This split
> > is initial, and can be changed later
> 
> The 0001 patch requires this, but it's not included until 0003.
> src/include/commands/session_variable.h
> 
> Each patch should compile and pass tests with the preceding patches, without
> the following patches.  I think the regression tests should be included with
> their corresponding patch.  Maybe it's ok to separate out the changes for
> pg_dump, docs, and psql - but they'd have to be merged together eventually.
> I realize some of this runs counter to Julien's suggestion to split patches.

Note that most of my suggestions were only to make the patch easier to review,
which was mostly trying to limit a bit the core of the new code.

Unfortunately, given the feature we can't really split the patch in many and
smaller parts and expect them to be completely self contained, so I'm not
against splitting smaller chunks like psql support and whatnot.  But I'm not
convinced that it will make it easier to review.