Date: Tue, 12 Apr 2022 07:50:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Georgios <gkokolatos@protonmail.com>
Subject: Re: Fixes for compression options of pg_receivewal and refactoring
 of backup_compression.{c,h}
Message-ID: <YlSwtX6xXipArwJ5@paquier.xyz>
References: <YlPQGNAAa04raObK@paquier.xyz>
 <CA+TgmoabKxkyZ5oY8TXb7ZAUC6gsRA1ojMM0+TUZbR61HEUvog@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dR40omU1+onpw7Ke"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoabKxkyZ5oY8TXb7ZAUC6gsRA1ojMM0+TUZbR61HEUvog@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YlSwtX6xXipArwJ5%40paquier.xyz>
Precedence: bulk


--dR40omU1+onpw7Ke
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 11, 2022 at 11:15:46AM -0400, Robert Haas wrote:
> +1 for this in general, but I think that naming like
> "compression_algo" stinks. If you think "compression_algorithm" is too
> long, I think you should use "algorithm" or "compression" or
> "compression_method" or something.

Yes, I found "compression_algorithm" to be too long initially.  For
walmethods.c and pg_receivewal.c, it may be better to just stick to
"algorithm"  then, at least that's consistent with pg_basebackup.c.
--
Michael

--dR40omU1+onpw7Ke
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJUsLQACgkQnvQgOdby
QH3u0hAAhrnos5Pra+n4FBW/Ee679dEWpkApBgJcqU7dmke5SbsHpCvFL51UrBM9
11Uvp7Bu7Xmw726aOOMVaOYdLAnesYBwPQW/Ds+NsoMcJ3b2bOBy2wemsPMBbph/
9lcQmEJgC1j+WzBBp7czLaxqbyJ4awn1IR3yYWD25kjXPOwhsfkVFzXqAOOE5uWJ
VBAwrH9e+17D1Zkb/FbdoYOeaP+RNvfAqAdtxytYf1ev0EZ7QgKiB1UfeUGLw+qk
ZWfqdzlRUsFDZ7tljBwX41HPeCffze+7cHWpCg4jj8SdcUDlu4P2IxIm/gLy2aZz
Piy+vcMMcFGivCMDtF6EPJKJtAvAqJPp9MUTMWIVaIofWaL9T4/Pk+sZJNN7KxVt
8c/mEp/5FL5QnQHI0FLdEukm5nOFSV3nyPt+k4/4khRNorD+DiLhPb2CGWBfs8Ce
anE4g5kYdZMmNlSKveYqKcEuwC3dcOvoT+5HcTqU3Zwglejlmo1WKD42VxWYbcRe
9zagPLy3qb7O/B/x8t3b47Hi7tBoUH7B3zOJ3QFIIEVSFKRPhStNMqBhPXrUXFbm
hiT2t50NM2iA7XjzkC+YieljkFHypcu6mLiOX6W/pfwFCh9lG4P9crw6U2P2DsAA
9Mg/v/DKxM7k1yGLhV9pg1hMcB9ck1iEg1BT/VxJp4IM/VBPTm8=
=J0RU
-----END PGP SIGNATURE-----

--dR40omU1+onpw7Ke--