Date: Thu, 14 Apr 2022 06:18:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: Fixes for compression options of pg_receivewal and refactoring
 of backup_compression.{c,h}
Message-ID: <Ylc+JXBBTfqidtPc@paquier.xyz>
References: <YlPQGNAAa04raObK@paquier.xyz>
 <Pw7ltgmMRlWiJ8w3EW_1Paoeaf1QIJtV-c-U9UgF8f12w3wxpFbqwp97hr3OchnlOFetTA50zYcMQ3coWDutqP3a1qsG2SXOKipKY3lNqBE=@pm.me>
 <YlVE6E687KDOABoN@paquier.xyz>
 <YlZernJnRsqntRGC@paquier.xyz>
 <QYtEfeZ2bTdYAeqCR-5rQs_myRhJclxaVfun-OEVSPnauawRqris5UNUTnYtoFy_KnhCbsjtkEeoxvZgLT0UkZTMnMq65BOwklSwFqbvI1U=@pm.me>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cuNcTxqduOFXdShM"
Content-Disposition: inline
In-Reply-To: 
 <QYtEfeZ2bTdYAeqCR-5rQs_myRhJclxaVfun-OEVSPnauawRqris5UNUTnYtoFy_KnhCbsjtkEeoxvZgLT0UkZTMnMq65BOwklSwFqbvI1U=@pm.me>
Archived-At: 
 <https://www.postgresql.org/message-id/Ylc%2BJXBBTfqidtPc%40paquier.xyz>
Precedence: bulk


--cuNcTxqduOFXdShM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 13, 2022 at 02:58:28PM +0000, gkokolatos@pm.me wrote:
> It's really not hard to add compression level. However we had briefly
> discussed it in the original thread [1] and decided against. That is why
> I did not write that code. If the community thinks differently now, let
> me know if you would like me to offer a patch for it.

The issue back then was how to design the option set to handle all
that (right?  My memories may be short on that), and pg_basebackup
takes care of that with its option design.

This is roughly what has been done here, except that this was for the
contentSize:
https://www.postgresql.org/message-id/rYyZ3Fj9qayyY9-egNsV_kkLbL_BSWcOEdi3Mb6M9eQRTkcA2jrqFEHglLUEYnzWR_wttCqn7VI94MZ2p7mwNje51lHTvWYnJ1jHdOceen4=@pm.me

Do you think that the extra test coverage is going to be too much of a
burden?  I was thinking about just adding a level to the main lz4
command, with an extra negative test in the SKIP block with a level
out of range
--
Michael

--cuNcTxqduOFXdShM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJXPiUACgkQnvQgOdby
QH1v8w//dFW1clFE5qy/uh6IMuzJ0yRhhHRgH3q7ElZKyWxAtzpXM5ZEKskvt1OK
YIY65VJtWCDk7/VdUUZ+pNnHnM329CSEThxn2eH3sIPe9idpyirN1Yq3hW3ibPp9
GpoblJ4ylfls3Xk5+g2LWbqmq3Q0ed6Kn21IDTkAzzlzTUsS5+m+qKxaBcPyxwZx
sUoBe7gQFq4FAT1AsBXrkbRGFKqIcRnZP7mcJFHreqY5GjSLDPGdIwcGQKyru7FP
PELj38tna9JcpAI8kVz3+FvS6vgC2s+47qst4vAYO75tlzN4QGT0XK2edJKRSRFz
GeI3bevMzrfn0zqPldHK8bVsNehZxVUkxqMY8XAtv7WrdBjuiNULpdCyVyewuKt7
JYhLRYFNghjQFXbX4BwJx7PK05pWXsc+IAfynRapCqqbq6mHO8+Nwk/vQDzTMbLM
6jl0Ik5JP84y3RqhUbRR9SfkDp9OFXCXbhX3eL3jrNomzrPzidekhALGNgWytmBf
0ZTmiwpMdhIo9ShCYUEoskUJ7Fo2mKU39W0C1sSW5DpPeyjlXXelQg2yEvGMyN+g
FJu8m1mcelg+WXGvKQqpDnTEmLu/n5GcWTGiLlT2+xXIIhcJ98gaoKzA/Af6T03T
ONhV7gdA8zCqE5W/pA/n580+Ed+O8oYXy9J3oaWWJbIwakLNX+M=
=irMy
-----END PGP SIGNATURE-----

--cuNcTxqduOFXdShM--