Date: Sun, 17 Apr 2022 13:17:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and
 recovery_end_comman
Message-ID: <YluU3C4i8sHoVeOQ@paquier.xyz>
References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org>
 <3385143.1649353230@sss.pgh.pa.us>
 <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
 <3386734.1649354265@sss.pgh.pa.us>
 <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
 <4015413.1649454951@sss.pgh.pa.us>
 <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
 <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
 <YlT23IvsXkGuLzFi@paquier.xyz>
 <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qiufC9HJvalZPqFC"
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YluU3C4i8sHoVeOQ%40paquier.xyz>
Precedence: bulk


--qiufC9HJvalZPqFC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 17, 2022 at 08:56:33AM +1200, Thomas Munro wrote:
> Under valgrind I got "Undefined subroutine &main::usleep called at
> t/002_archiving.pl line 103" so I added "use Time::HiRes qw(usleep);",
> and now I get past the first 4 tests with your patch, but then
> promotion times out, not sure why:
>=20
> +++ tap check in src/test/recovery +++
> t/002_archiving.pl ..
> ok 1 - check content from archives
> ok 2 - archive_cleanup_command executed on checkpoint
> ok 3 - recovery_end_command not executed yet
> # found 00000002.history after 14 attempts
> ok 4 - recovery_end_command executed after promotion
> Bailout called.  Further testing stopped:  command "pg_ctl -D
> /home/tmunro/projects/postgresql/src/test/recovery/tmp_check/t_002_archiv=
ing_standby2_data/pgdata
> -l /home/tmunro/projects/postgresql/src/test/recovery/tmp_check/log/002_a=
rchiving_standby2.log
> promote" exited with value 1

Hmm.  As far as I can see, aren't you just hitting the 60s timeout of=20
pg_ctl here due to the slowness of valgrind?

> Since it's quite painful to run TAP tests under valgrind, I found a
> place to stick a plain old sleep to repro these problems:

Actually, I am wondering how you are patching Cluster.pm to do that.

> Soon I'll push the fix to the slowness that xlogprefetcher.c
> accidentally introduced to continuous archive recovery, ie the problem
> of calling a failing restore_command repeatedly as we approach the end
> of a WAL segment instead of just once every 5 seconds after we run out
> of data, and after that you'll probably need to revert that fix
> locally to repro this.

Okay.  Thanks.  Anyway, I'll do something about that tomorrow (no
room to look at the buildfarm today), and I was thinking about
replacing the while loop I had in the last version of the patch with a
poll_query_until that does a pg_stat_file() with an absolute path to
the history file to avoid the dependency to usleep() in the test,
splitting the fix into two commits as there is more than one problem,
each applying to different branches.
--
Michael

--qiufC9HJvalZPqFC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJblNwACgkQnvQgOdby
QH2V4Q/+Lio8T/wa6W8pc3cNU6NBmcbU1ClR2zC7DuUNn0uGjf38rWYmwCdyX5bx
3slbJg5XSBjoBD8eH1XaKElgqx7DgRw0YlhO+klKIePkUwABE9+rI58h/kTnL/1M
oCTTBPnezpufwH5RNXJ/z+jodII2ZCQAUBM8gv+z3Uq1pEz61nJkORxfZoelaKnP
zr9kVEYLKoOzc6Xd5JajEqqH9VyxOpXaojM3u5j23YU2EO+D8+wcCInZd3H0jeFD
xS+5dhaB8NG7tdcqQU6NXFkrvef90RmRTzDmbQuMfEph8/LuXll0Ge3HiOef7Qor
710wxC6w49AG9xjwbhy4RBOWi5we608RLMhvPQn8SL0dQHiivyokLY14zFImCFgW
DpMH9Pvuw7AaUNtchd2vYnCY/U1o+v4ksrvLN14anyJ+jkEOpbfCpGvf8aJ9IVdw
M7pQOXoHjGGe0opHaYuSqgOb2d41y3zFsj2LzYFN3FnSeQM4Sj8E9VyVsXFIIN1W
FBGwT7wX1u+L+BPB07ja16Dn5rLrrZUhjr5GYxizlo8KmL+gekqH5Y1BEJ82et1E
Uip6DrOhaLqJUz1b+P2cOGhtFF23rSKcEm9yB9OL3HnmhrgwCe6bNYH2KuUuSmpI
y2LCZbLfd561X5Uf6j7zaSMq9IB6jNzcSD9AVc1Pb+OaSM8KHI8=
=l1BX
-----END PGP SIGNATURE-----

--qiufC9HJvalZPqFC--