Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngHLk-0007Qu-Mn for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Apr 2022 02:42:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ngHLj-0004nb-HU for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Apr 2022 02:42:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngHLh-0004nS-Rw for pgsql-hackers@lists.postgresql.org; Mon, 18 Apr 2022 02:42:47 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngHLe-0006MP-LG for pgsql-hackers@lists.postgresql.org; Mon, 18 Apr 2022 02:42:45 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AD0645C00DE; Sun, 17 Apr 2022 22:42:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 17 Apr 2022 22:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1650249759; x=1650336159; bh=CkSdzCX9qN cumUWZnmRrskA9xmTgrT8Q19Ch2ps6OFM=; b=jd/hRGmEJ/wf2wdtfRNPHpvrEa Sd4cX5gFYlmyzCLkL9ShLi5IeibA2ejoh3mTWstPRgKrIFhVqC3HWtV3cS19VeR3 cdioCudJlYj3SxlxSFG4rW4/9Nu9Ch8Gg5Hqm8vJ9+siOtwQFb1Y9E+j+Tsqk7ap j+KNd37Jsw5/0v9KPmFbB1O8tanv1iXgCgARP3cLV9toqeIvsDCAXGjp7ojshTMj 2uaWh3k3I6z2jtvA5aEQwu0MOGTg1wjPM07T7y5hzckqE8yxjiVUrHgQb3OCXlrs gYkhpybj3HTEtUKiK1QGddVXol8ruR1R4VPAMfHAw42eQAClcsTPf73QEo+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650249759; x= 1650336159; bh=CkSdzCX9qNcumUWZnmRrskA9xmTgrT8Q19Ch2ps6OFM=; b=d awcaFOLn+cA6qSP6LSTZ2tVJdwniu4nK6mFPhS84uU/YA0RSIiowv/5Vm3wSRa2c 4ZhmAGYkbUSH5/khLnsPoQSBx0CTRbNb2o2wNM+UmOq/7W6LoNzeF50OGnRDkt+K AwYGhb+JZodDEGaTdI0OU6WLOPFpSxsb2pD1oyo2S0uVb7iSOvatW6EVbYp8xkhf Uh/6/EcKwdI1ARItfCMXSV441shlrfrl5N+55TCaBw7VKUKVMZJrlYaVfMM3U2Pk x58+mbB879CJUU25p5ZPiSPXbIO8mjmfqe4gxfvt66t7mOmNHjPTA0aya1sNUJoc E46VaK0H0hUOKtpmwPyDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddttddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtroertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeehgedtueehkeetgeeuvedtleel keeggeefteefjeejgfekheeikeevjeehudejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Apr 2022 22:42:38 -0400 (EDT) Date: Mon, 18 Apr 2022 11:42:33 +0900 From: Michael Paquier To: gkokolatos@pm.me Cc: Postgres hackers , Robert Haas Subject: Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h} Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZFkkfiup1EpAsp1k" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ZFkkfiup1EpAsp1k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 14, 2022 at 06:18:29AM +0900, Michael Paquier wrote: > The issue back then was how to design the option set to handle all > that (right? My memories may be short on that), and pg_basebackup > takes care of that with its option design. I have looked at that again this morning, and the change is straight-forward so I saw no reason to not do it. And, applied. -- Michael --ZFkkfiup1EpAsp1k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJc0BkACgkQnvQgOdby QH3mEA/9E3WWOzl+H/kbso6s8T3Ns09DFpL3RL6dzEsDg4e4P1+61/ks4kipJDqT /J31wsI0iGQWEyi+tZ8x8uKBUi7kcqvRlgU8FMHPQU2udZYv8WwmIyCOxSUynDSm gKHUXLH1p+vBLBpd4FjpKZh1ySwsxBM0VwpyDIWiqswPSLqbaI3KTKVgcr/S7CP+ I/0TVzw19lg9y6pGQOlYBeQfJKg4KKmqN0Ka0UcOkq7KIPP9y6hTj1veqKKU8o+5 0BC8w9XJGdB5OI06rOM+nXOWrpBDhhmzgclhVRqi5jhgmqvh5vLt2zWElFOuZmhj s0xG508Ix0f2evX78NwXtEBwYI93XEqncUK+5fZKFscRVyg9NGvZI99yjlj4KNmN kGFWsMse82BFPvpKWSXwEPv5U/tR2Rip40kfaKgn9lZxpqNIR0do8Q1fxk7lXcjf gwtd0e+lOvQ/XycYQyzxhsm2V1zHZ9SPQ91+i/A1u/hP9W2MJHN2bflw/DXpMqS+ 4tx3YFmBfJU9Vji30+wlG7xh4ZBbkhvAFsn+pCcQiZy7AYS8jCGsVQ6JQ24U8mcw P+RJgmA87ny6XwkzuoUYH0Em+qWn0ggFzv666FaZYEjsS9Ms4MZmX7np3raXuDeN raEiMvK2zKvjXltC8yxJVBhLhJVsmexOIBn8rdbOGPHY9R6yStQ= =2/H5 -----END PGP SIGNATURE----- --ZFkkfiup1EpAsp1k--