Date: Mon, 18 Apr 2022 13:55:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and
 recovery_end_comman
Message-ID: <YlzvMeOnn/u8Z8MH@paquier.xyz>
References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org>
 <3385143.1649353230@sss.pgh.pa.us>
 <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
 <3386734.1649354265@sss.pgh.pa.us>
 <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
 <4015413.1649454951@sss.pgh.pa.us>
 <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
 <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
 <YlT23IvsXkGuLzFi@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TMNXFLXy4gkJ9BOE"
Content-Disposition: inline
In-Reply-To: <YlT23IvsXkGuLzFi@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YlzvMeOnn/u8Z8MH%40paquier.xyz>
Precedence: bulk


--TMNXFLXy4gkJ9BOE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 12, 2022 at 12:49:48PM +0900, Michael Paquier wrote:
> This comes from df86e52, where we want to recovery a history file that
> would be created as RECOVERYHISTORY and make sure that the file gets
> removed at the end of recovery.  So $standby2 should choose a new
> timeline different from the one of chosen by $standby.  Looking back
> at what has been done, it seems to me that the comment is the
> incorrect part:
> https://www.postgresql.org/message-id/20190930080340.GO2888@paquier.xyz

acf1dd42 has taken care of the failures of this test with skink, and I
have just taken care of the two races in the tests with e61efaf and
1a8b110.  I have left e61efaf out of REL_10_STABLE as the idea of
relying on a poll_query_until() with pg_stat_file() and an absolute
path would not work there, and the branch will be EOL'd soon while
there were no complains with this test for two years.
--
Michael

--TMNXFLXy4gkJ9BOE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJc7zEACgkQnvQgOdby
QH3Qpg/9Fj8sWldSDWq9K8g6iAZjLIU1S3+0/FyPvxR3Ud8K6suJfxxFA6AczzB2
4pwJCbw3gT14+fqBDjWzBa16LT6w6+1B9pjHo67T5ckUSm2PtVGV57UDze6BMb6M
2tGQsn8YfNIBuTHVgitmRqzO4U0ruzvXtEhHbZIDV00filzIAh4GK3H0OujsYbop
vbFHyagug9phS3dPVWO8kdaW1yXFdeE4toTAGz/2wRdRb3FD2tAyx8sFxuDTgAir
R2EERdtrz3JXHoC5/KoESLxaz2GYENnQDkkiTvgXPF83AfO7yPTWcrYyYEIFHgOd
Ka/3JvXGZFHIOz2ZYibAMQcg5dmQjt39nVJhHuN/EExnqRWO/WK1QIuO9Iwwr8nQ
tgW7DfKBz1WmXG5F/2wcBw2BQyJGhQHX8URkZZU0HHDh266VdIjcrC13rNxtZLf1
6wNrdeLEiZrOSg73v7bOf/MB1Fge2W7YWPDpTJcbWU8WoRuVp6kKq7+BdEBsx/KV
S3xHR9imke4Q6LS6cmgzeNJ3e6QzzI0ZJrXleASOHLeJnFlGlE+FFvOJEOMB3ACL
25sFJSZ6lRhnAzGLu6uUC5XO3hSxBmYKBiNvQZIYYhvsk7508PLjjaqy0tRa8iD9
/n3zikUwTFjybzObZjk5L/4nivxVmuOLHxMrH9h5bagYzCbJNZo=
=RhT7
-----END PGP SIGNATURE-----

--TMNXFLXy4gkJ9BOE--