Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhOAo-0003V7-KM for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Apr 2022 04:12:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nhOAn-0004Fa-A8 for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Apr 2022 04:12:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhOAn-00049l-0f for pgsql-hackers@lists.postgresql.org; Thu, 21 Apr 2022 04:12:05 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhOAk-00076L-QF for pgsql-hackers@lists.postgresql.org; Thu, 21 Apr 2022 04:12:03 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E4F953201E88; Thu, 21 Apr 2022 00:12:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 21 Apr 2022 00:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1650514320; x=1650600720; bh=u6Xk+an7p7 xwa1vk7Lqd0ZCHK1K3Wfl0vHtGXKYPDgQ=; b=W7Xd0uXq81w1s4CrgETM50Nfke r6ZYrHKj/qvGqjPJtW1R7OFQ6AsxfH0odA82Vjo9w7XYc8JWx8XerCBkfMc7zc2Y FUIlPzeD7JcPBDyzzDmJZ4qSvay+laLCOQa63a/bm9dvfS7pkMn2lc9RArl7fuF6 3MXp9BGdt6Ws8XTucGuymqC2Wysv3sjT6kJguFblc9iJAov5LRR0/rCBe2BVIh5q H9l0uGVKaTCEc139lZvTUg8MLwWDqPDXSp0tJ116IBbv/fplA6QEAuIU6byibu+D 2JyDRVUuR3tUIi4luf7O93wTt/781iEOw5/+euvYmW5tvQjuXtsms+RyDhzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650514320; x= 1650600720; bh=u6Xk+an7p7xwa1vk7Lqd0ZCHK1K3Wfl0vHtGXKYPDgQ=; b=t VujWxDBS02QubJ/lKowlR3UJA24J4B+5nrFQJFHG5iq8gjiULshyhHPezd1TBEEL baCLzpPtgWdpTM17Xgo4SWRoWh+tTFhfB7KxbAtCw5kYdgY/jOUSHk1ZWg5pBT7y DhRyVpjjEsfbcmNwRYcqorpAxCgn9UAiOrz1aNxUpLYTWs1uflwhocU705TUi1iv jJKhKQ1K1iYqtlAXSdfuOvmrBf5zznmwhvWyUNiWASf+/RKXwRejs4IhYmiUJxPD kgC4sClU3fMreo0xZ95D/S335U/tzwdlqEWsbNX5pkTTHr8P/tf9aOsiHvglgavQ TKK78GM795YIxhQyVkQQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtddugdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtroertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudelheeghfekfefgfedthfek uddtvdfhudekgeegheeikefflefhleekheetfeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Apr 2022 00:11:57 -0400 (EDT) Date: Thu, 21 Apr 2022 13:11:49 +0900 From: Michael Paquier To: Andrew Dunstan Cc: Tom Lane , Noah Misch , Andres Freund , Erik Rijkers , Robert Haas , Alvaro Herrera , Mark Dilger , PostgreSQL Hackers Subject: Re: Postgres perl module namespace Message-ID: References: <2361941.1650303832@sss.pgh.pa.us> <02188900-ba1e-8c6c-c7dd-98294f39c23f@dunslane.net> <2364418.1650305263@sss.pgh.pa.us> <03909eb8-21ce-ca68-fea0-cd338e35ad59@dunslane.net> <6790e47f-aa12-e28b-e123-3fbe46f78513@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q7quBmlmWE4s9PzZ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --q7quBmlmWE4s9PzZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 20, 2022 at 03:56:17PM -0400, Andrew Dunstan wrote: > Basically I propose just to remove any mention of the Testlib items and > get_free_port from the export and alias lists for versions where they > are absent. If backpatchers need a function they can backport it if > necessary. Agreed. I am fine to stick to that (I may have done that only once or twice in the past years, so that does not happen a lot either IMO). The patch in itself looks like an improvement in the right direction, so +1 from me. -- Michael --q7quBmlmWE4s9PzZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJg2YUACgkQnvQgOdby QH3ppQ//eM1KxpwP4jCovYVPxmsHH9u8lMK5QK1T6sAhyqqJVsg/D68WC1AOTkj2 c/MPHzZg4pwhiwkZjJzVI31WEuLhX4ImUZbp6Fucn3W2frE4izpl+flcQ/nuvmXa IaOy7Ins4xtHhjwBRqQXonCbTFFVBc+ngvyej2zDjAHc9v2mo/KeXYPckmhh3JIp uLFlNeE1g606NtDdn92AjDcBiz1SfIb7aINlfmph2CqICKkDUtYbAxz136dJSV3K jLDikDnzuBeASJKD3ABsTWfF9Ah7aKk1jrQemcCrcC/qrt3vPMhIH7aUq9vRS5Ow osIjKWoC8qYKIaPpUx4PySwpc3dxvCVXsUxyIQD/bUZx8KuMzJgnXo8E0mbpp6ow 0EHcEN8nIMWKwQN8i/e4sLBIHMASiBtrjuGTjpm/TuGZP9btC1BZnDokOVak1zmc 3eX3GNJwTwDhHcX7KjJrvb96/iyOZYYyw1nA7zQY435t1HI5eVMPgDV/DSvwRoBz ZY+mALJQy0v2ev3SMf6ntErvz8Sy3AJCbT74n0jOWwTT5FXdptGAnMbjpvAp5y7q qFe0eKpUqynY3PsYuGYm5Y05d1hMmdi/CnuSI4g1mURvomm750E8yIJYbtySVYFz 3Bhf5J906Gsl2m2Wnvn7jlvwdNYwbisMmk1rRZ7PdiwIcbpEWvo= =C3tw -----END PGP SIGNATURE----- --q7quBmlmWE4s9PzZ--