Date: Thu, 21 Apr 2022 16:56:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Checking pgwin32_is_junction() errors
Message-ID: <YmEOJwmmKPugH41o@paquier.xyz>
References: 
 <CA+hUKGLfOOeyZpm5ByVcAt7x5Pn-=xGRNCvgiUPVVzjFLtnY0w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VY3t/Q+qavL/lO0g"
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGLfOOeyZpm5ByVcAt7x5Pn-=xGRNCvgiUPVVzjFLtnY0w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YmEOJwmmKPugH41o%40paquier.xyz>
Precedence: bulk


--VY3t/Q+qavL/lO0g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 24, 2022 at 04:30:26PM +1300, Thomas Munro wrote:
> I think it'd be better to add missing_ok and elevel parameters,
> following existing patterns.  Unfortunately, it can't use the generic
> frontend logging to implement elevel in frontend code from its current
> location, because pgport can't call pgcommon.  For now I came up with
> a kludge to work around that problem, but I don't like it, and would
> need to come up with something better...

The only barrier reason why elevel if needed is because of pg_wal in
SyncDataDirectory() that cannot fail hard.  I don't have a great idea
here, except using a bits32 with some bitwise flags to control the
behavior of the routine, aka something close to a MISSING_OK and a
FAIL_HARD_ON_ERROR.  This pattern exists already in some of the
*Extended() routines.
--
Michael

--VY3t/Q+qavL/lO0g
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJhDicACgkQnvQgOdby
QH10NA/8C715AmDr56DrsIF7sYDhRrx7JnOPsnhMav26WAj0QQNXNeUmSgF0NuLB
PVl22oOSohftuh8wgB5TM3fEOosfEOH37io6EbAqyWphO8b+BR1bbiLTNccyLAP1
PPDSWxc8GPXFcH5Ut0tfwiu1y5hTSdH+o7TD/FLoYxKcORRLNurWRhb6wRbwS/ng
E+yiHZyp0nMupRgjwhdtJ6MMcpHA5Cin0Il8J1s2ikhk8hJJhIUwd1xZDeX/whVd
qAzDIeexEi6JWaO2THIGIbcvA+RCNTcfd+Rc/vFJfBM56P4nGR2EpIds16w1KBPJ
LZvMZ23c81mMfPQcuNYVJbZsxFqt5SETkbv+tCtV5Upy68J0KaOlhq+pmlJ2r6f6
fClpXwhhvMa6Poq+Pva4sOSMtPdvNJZv3+uQW24o87u0g+qv3xAvpZ51tQOt2LbX
6iMDUZ6ZefNQ11CPWarouAD1bEypeaucDa/lrGQOYxLTc1UAVuyq/wXjViT6Z7+a
adCqgIsB8jtRCr/ZnlyHPbBWH3X+nMgXtnROtYIw2Cc2MCpTsT1HpfmZW0KLvEll
aE8gXjwVE2ltYfpDXq3mRxd3Nh2Z7gmuwd72ZA1X/OarN9nLM1PgtU8YfvD3lwMW
m5KL7pCD3i84A47cPk5SCzweEST3vxG8Q4/mFNalCJUf/tfzqwc=
=ynnr
-----END PGP SIGNATURE-----

--VY3t/Q+qavL/lO0g--