Date: Tue, 26 Apr 2022 14:13:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add contrib/pg_walinspect.
Message-ID: <Ymd/e5eeZMNAkrXo@paquier.xyz>
References: <E1ncj1z-000rJo-Kh@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="asPQCtVj4HWKJ0SS"
Content-Disposition: inline
In-Reply-To: <E1ncj1z-000rJo-Kh@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/Ymd/e5eeZMNAkrXo%40paquier.xyz>
Precedence: bulk


--asPQCtVj4HWKJ0SS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jeff,

On Fri, Apr 08, 2022 at 07:27:44AM +0000, Jeff Davis wrote:
> Add contrib/pg_walinspect.
>=20
> Provides similar functionality to pg_waldump, but from a SQL interface
> rather than a separate utility.

The tests of pg_walinspect look unstable:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dtopminnow&dt=3D20=
22-04-25%2001%3A48%3A47

 SELECT COUNT(*) >=3D 0 AS ok FROM
 pg_get_wal_records_info_till_end_of_wal(:'wal_lsn1');
- ok
-----
- t
-(1 row)
-
+ERROR:  could not read WAL at 0/1903E40

This points out at ReadNextXLogRecord(), though I would not blame this
test suite as you create a physical replication slot beforehand.
Could this be an issue related to the addition of the circular WAL
decoding buffer, aka 3f1ce97?

I am adding an open item about that.

Thanks,
--
Michael

--asPQCtVj4HWKJ0SS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJnf3sACgkQnvQgOdby
QH3jng/+LYsoPCpD2ffJBhwaRvBUfB84OevsfRajXnlOvS9Y4enImJUSCbWViBDT
r14U7oUSYsjNrAPMeG29kLi8cAEJ1844mLM/wUKadj+OEQTlEVQtcoKgoEWWjjt4
EcGJ1ktoXzlkaH/j/X1gSIs+8s96bkvkATB/dliAn0wixNENCZTihu0CL8MBRmZr
Gawb7DmXIW0S9j0Szm9wcSMkrO6tBjPmjqjeZBpe0OGFBvnFbdvYCMv5J2Of0SQQ
3rdwxjX2Z5C+vU8ntHCmNsFZ4SclMNMAoDo5F1c3IFCvWcZw/xi5C86bqZTzLbMv
05b1ls1sk8qhAeePBW8riuFFKbipl6fxrKHKIb+D94OULUBKK9zfkprpKKdHnL4p
xzofhJWCbNHiiakn+ig93ytxfjnHLFUFBjirTvvsktAdYZMjylnVywBhMGIQS0dW
rXWnzDHGF1h5LfRBm+TGAkFoTOmxzEe5kOLzlGpnZvvnHwawDsVvWMUH8MHqDU22
t+ZlLHff/umIMdGeZXJ+yWVz8KUHevyookEmQueqgV+ZqyltPpafP4vaJNIIrV9t
UjppUDZObM/z9TRZLRN3O8iKFQP/9AnJv35RDMad89jQV+t85wqfAQMN4UGzPLJa
2OD5GrE5E3Q3I2TSnvn7DVyN5iKzdmKxQXXdB+uo24rMnM7htN8=
=8aDT
-----END PGP SIGNATURE-----

--asPQCtVj4HWKJ0SS--