Date: Tue, 26 Apr 2022 11:42:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Christensen <david.christensen@crunchydata.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Message-ID: <YmdcKVx3CIp3cx7O@paquier.xyz>
References: 
 <CAOxo6XKjQb2bMSBRpePf3ZpzfNTwjQUc4Tafh21=jzjX6bX8CA@mail.gmail.com>
 <CALj2ACU-_HixN-rz0tKsab6b3w-+3w733ceUW6oKSJ7Pgp2R+Q@mail.gmail.com>
 <CAOxo6XKDO_q2dbUaz-hcLs1-d5d=OdMecm=A3tRYrb=yngVsQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QPJWeT3OhblTfCIu"
Content-Disposition: inline
In-Reply-To: 
 <CAOxo6XKDO_q2dbUaz-hcLs1-d5d=OdMecm=A3tRYrb=yngVsQw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YmdcKVx3CIp3cx7O%40paquier.xyz>
Precedence: bulk


--QPJWeT3OhblTfCIu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 25, 2022 at 10:24:52AM -0500, David Christensen wrote:
> On Mon, Apr 25, 2022 at 6:03 AM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
>> Thanks for working on this. I'm just thinking if we can use these FPIs
>> to repair the corrupted pages? I would like to understand more
>> detailed usages of the FPIs other than inspecting with pageinspect.
>=20
> My main use case was for being able to look at potential corruption,
> either in the WAL stream, on heap, or in tools associated with the WAL
> stream.  I suppose you could use the page images to replace corrupted
> on-disk pages (and in fact I think I've heard of a tool or two that
> try to do that), though don't know that I consider this the primary
> purpose (and having toast tables and the list, as well as clog would
> make it potentially hard to just drop-in a page version without
> issues).  Might help in extreme situations though.

You could do a bunch of things with those images, even make things
worse if you are not careful enough.

>> 10) Along with pg_pwrite(), can we also fsync the files (of course
>> users can choose it optionally) so that the writes will be durable for
>> the OS crashes?
>=20
> Can add; you thinking a separate flag to disable this with default true?

We expect data generated by tools like pg_dump, pg_receivewal
(depending on the use --synchronous) or pg_basebackup to be consistent
when we exit from the call.  FWIW, flushing this data does not seem
like a strong requirement for something aimed at being used page-level
chirurgy or lookups, because the WAL segments should still be around
even if the host holding the archives is unplugged.
--
Michael

--QPJWeT3OhblTfCIu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJnXCkACgkQnvQgOdby
QH0TxBAAhtc1jCQTCRy3vGQD2rOdNixCom+B5s8ssqTKtuO7PcAkc3Qwn4TzjPPd
89TO7lpVmyfzujpQ4xJL5ByO9w2QvPdEr+FiJTkmb3egu+TVCbx/ZHrp7YQUWOgU
yEZA7/Hb3olpvPnVCidbhRuU4Ams7s+Go4i+6A/em/EQ3PFF/zNkhGQjoX9QtF2g
G+cxKgPKkVcPz0UffSqFmZK/KuUEdRzbXhbo5bOa4WaAlezPwsLJ4yuzt3NqyJ53
ShzD/w/f3Z7uTwJedGZXnZjifcLjDlN7X0W/uPVftzJSRTSv+1l6jTb3JMKVo5EW
30PPbxuRYneBP+rU13TPeB5gYGj3L0kf3vshiPyrSy2fNTP73QtsJYo3WQB5POV5
3HIFlB3fnZS1pVvIX541aduoxlAZ5uqwEnkrQreUDkgwsXbB7kb3ZDeG6Thz4w2i
8i/KYXr4WY1tzDKXrgmGljdAvQ3At2TOzvO5w3/HHOyeVoCRdfLqHnTNH9awC11x
e60LHZPaDO9ifSxBEJbwhLTXXH9oiRf2VdkqUCFE/OCGPW3nBzxMjcU+W416VgHA
viAmMsJpEJlg8VEhZn3oWZnp/HKc9eX5klU2g5bjd16IL/zmIT9+Fzd3f+C7gK3D
Yg/1MuOQFK45+2WW7AoFgOoMGOH8OflYEar2KIR65qyHwL9xYH4=
=G9h6
-----END PGP SIGNATURE-----

--QPJWeT3OhblTfCIu--